RE: gdi32: Remove unneeded check. (Coverity)

2009-01-30 Thread EA Durbin
> From: kai.b...@gmail.com > To: robertshear...@gmail.com > Subject: Re: gdi32: Remove unneeded check. (Coverity) > Date: Wed, 28 Jan 2009 10:32:40 +0100 > CC: wine-devel@winehq.org > > On Tuesday 27 January 2009 18:29:10 Rob Shearman wrote: > > > It doesn&

Re: gdi32: Remove unneeded check. (Coverity)

2009-01-28 Thread Kai Blin
On Tuesday 27 January 2009 18:29:10 Rob Shearman wrote: > It doesn't make much sense to leave the lcdfilter variable in the > function if you're going to remove the if condition depending on it, > since it only has one other use. > However, It might have been the intention of the author of this co

Re: gdi32: Remove unneeded check. (Coverity)

2009-01-27 Thread Rob Shearman
2009/1/27 Kai Blin : > > lcdfilter = FT_LCD_FILTER_DEFAULT is hardcoded, so the check is always true. > > This fixes Coverity CID 816 > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 1ca6953..dfbcf2f 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -4783