Re: MSI: free allocated buffers

2004-12-28 Thread Michael Stefaniuc
Joris Huizer wrote: Mike McCormack wrote: ChangeLog: <[EMAIL PROTECTED]> * free allocated buffers The other daty I saw a lot of patches changing things like if (buffer) HeapFree(GetProcessHeap(),0,buffer); To HeapFree(GetProcessHeap(),0,buffer); Why are you adding new code with

Re: MSI: free allocated buffers

2004-12-28 Thread Mike McCormack
Joris Huizer wrote: The other daty I saw a lot of patches changing things like if (buffer) HeapFree(GetProcessHeap(),0,buffer); To HeapFree(GetProcessHeap(),0,buffer); Why are you adding new code with the if() statement in place again? Note all these patches were written by Aric, and I most

Re: MSI: free allocated buffers

2004-12-28 Thread Joris Huizer
Mike McCormack wrote: ChangeLog: <[EMAIL PROTECTED]> * free allocated buffers The other daty I saw a lot of patches changing things like if (buffer) HeapFree(GetProcessHeap(),0,buffer); To HeapFree(GetProcessHeap(),0,buffer); Why are you adding new code with the if() statement in

Re: free allocated buffers

2004-12-28 Thread Dmitry Timoshkov
"Mike McCormack" <[EMAIL PROTECTED]> wrote: > Index: dlls/msi/action.c > === > RCS file: /home/wine/wine/dlls/msi/action.c,v > retrieving revision 1.55 > diff -u -r1.55 action.c > --- dlls/msi/action.c 27 Dec 2004 19:12:35 - 1.55