Re: for the record, my ole32 binary tree search patch is correct

2009-10-28 Thread Yuriy Kaminskiy
On 28.10.2009 20:30, Vincent Povirk wrote: >> If I've not mistaken, that uses lstricmp internally for comparing keys. > > It uses lstrcmpiW, which according to MSDN can behave differently > based on locale, but I don't think the Wine version does. Note, that, it is not only difference in >0x7f "n

Re: for the record, my ole32 binary tree search patch is correct

2009-10-28 Thread Vincent Povirk
> If I've not mistaken, that uses lstricmp internally for comparing keys. It uses lstrcmpiW, which according to MSDN can behave differently based on locale, but I don't think the Wine version does. The comparison is in the propertyNameCmp function. I think that the MS storage code probably does

Re: for the record, my ole32 binary tree search patch is correct

2009-10-28 Thread Yuriy Kaminskiy
On 27.10.2009 22:50, Vincent Povirk wrote: > I sent the following patch recently: > > commit ee6856d874d687c4504914e61bcde3e6b8823bca > Author: Vincent Povirk > Date: Fri Oct 23 13:57:42 2009 -0500 > > ole32: Don't use IEnumSTATSTG to search for elements of storages. > > We use it to

for the record, my ole32 binary tree search patch is correct

2009-10-27 Thread Vincent Povirk
I sent the following patch recently: commit ee6856d874d687c4504914e61bcde3e6b8823bca Author: Vincent Povirk Date: Fri Oct 23 13:57:42 2009 -0500 ole32: Don't use IEnumSTATSTG to search for elements of storages. We use it to do a linear search of a binary tree, which is overkill. R