Re: fixing ReadDirectoryChangesW()

2009-09-12 Thread James McKenzie
Mike Kaplinskiy wrote: > On Fri, Sep 11, 2009 at 5:42 PM, Dan Kegel wrote: > >> Michael Pujos wrote: >> >>> I'm willing to resubmit this patch with updated tests >>> against current Wine, but before I procceed >>> I need to be sure it won't be rejected simply because it changes the >>> pr

Re: fixing ReadDirectoryChangesW()

2009-09-11 Thread Mike Kaplinskiy
On Fri, Sep 11, 2009 at 5:42 PM, Dan Kegel wrote: > Michael Pujos wrote: >> I'm willing to resubmit this patch with updated tests >> against current Wine, but before I procceed >> I need to be sure it won't be rejected simply because it changes the >> protocol. > > Server changes are tricky to ge

re: fixing ReadDirectoryChangesW()

2009-09-11 Thread Dan Kegel
Michael Pujos wrote: > I'm willing to resubmit this patch with updated tests > against current Wine, but before I procceed > I need to be sure it won't be rejected simply because it changes the protocol. Server changes are tricky to get in. You have to be patient and persistent. I think your best

fixing ReadDirectoryChangesW()

2009-09-11 Thread Michael Pujos
A few months ago I wrote a patch that addressed the following issues with ReadDirectoryChangesW(): "1. move and rename of files and directories in a monitored directory are not notified 2. the current implementation allow to only get one change (FILE_NOTIFY_INFORMATION structure) at a time. N