Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Alexandre Julliard
"Jérôme Gardou" writes: > Alexandre Julliard a écrit : >> You certainly don't want to add exports to kernel32 for that. Launching >> the debugger isn't hard to do in faultrep, plus you most likely want to >> do it differently from what kernel32 does. >> > Is this one too hackish for you ? Yes

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Jérôme Gardou
Alexandre Julliard a écrit : "Jérôme Gardou" writes: Well, launching winedbg instead of printing incomplete information is, IMHO, the best way to make something useful, and, as you said it, kernel32 is always builtin, as ntdll, and faultrep is too close of the system internals to be a tot

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Alexandre Julliard
"Jérôme Gardou" writes: > Well, launching winedbg instead of printing incomplete information is, > IMHO, the best way to make something useful, and, as you said it, > kernel32 is always builtin, as ntdll, and faultrep is too close of the > system internals to be a totally winapiesque dll. Afte

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Jérôme Gardou
Mikołaj Zalewski a écrit : > > Jérôme Gardou pisze: >> Let's rephrase it : most bug reporters expect the console log to be >> useful for developers willing to fix their problem :-) > Maybe I should have made it clear - I think that your patch, even in > the first version, was a step forward :).

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Mikołaj Zalewski
Jérôme Gardou pisze: > Let's rephrase it : most bug reporters expect the console log to be > useful for developers willing to fix their problem :-) Maybe I should have made it clear - I think that your patch, even in the first version, was a step forward :). As for the second patch, Alexandre

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Chris Robinson
On Monday 23 February 2009 8:39:22 am Erich Hoover wrote: > My suggestion (maybe this wasn't clear) was to normally > output the diagnostic information to the console, but if the console is not > available (if wine was launched from a desktop icon, for example) then to > pop up with a dialog. That

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Erich Hoover
On Sun, Feb 22, 2009 at 7:44 PM, Ben Klein wrote: > ... > #include and use isatty() would be the correct way to do > it. But is a dialog box that only appears when not being run from a > terminal really such a good idea? > Does wine have a global handle to a file descriptor that can be used in

Re: faultrep:display useful information in ReportFault

2009-02-23 Thread Jérôme Gardou
Mikołaj Zalewski a écrit : I've written a dialog about a crash some time ago to add to winedbg (http://www.winehq.org/pipermail/wine-patches/2009-January/068073.html). It's probably time to ask what is the status of this patch? If this patch gets accepted (Alexandre seemed to like the previo

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Ben Klein
2009/2/23 Erich Hoover : > On Sun, Feb 22, 2009 at 2:34 PM, Jérôme Gardou > wrote: >> >> Chris Robinson a écrit : >>> >>> Having the information there of why it crashed would be nice too, >>> especially if it's hard to reproduce. Knowing what the fault was, and where >>> (with a backtrace if possi

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Jérôme Gardou
Mikołaj Zalewski a écrit : > > I've written a dialog about a crash some time ago to add to winedbg > (http://www.winehq.org/pipermail/wine-patches/2009-January/068073.html). > It's probably time to ask what is the status of this patch? > If this patch gets accepted (Alexandre seemed to like the

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Mikołaj Zalewski
I've written a dialog about a crash some time ago to add to winedbg (http://www.winehq.org/pipermail/wine-patches/2009-January/068073.html). It's probably time to ask what is the status of this patch? If this patch gets accepted (Alexandre seemed to like the previous version, but pointed tha

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Erich Hoover
On Sun, Feb 22, 2009 at 2:34 PM, Jérôme Gardou wrote: > Chris Robinson a écrit : > >> Having the information there of why it crashed would be nice too, >> especially if it's hard to reproduce. Knowing what the fault was, and where >> (with a backtrace if possible) can give the more development-inc

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Jérôme Gardou
Chris Robinson a écrit : > Having the information there of why it crashed would be nice too, especially > if it's hard to reproduce. Knowing what the fault was, and where (with a > backtrace if possible) can give the more development-inclined people > information of where to look for the issue,

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Chris Robinson
On Sunday 22 February 2009 1:15:42 pm Erich Hoover wrote: > On Sun, Feb 22, 2009 at 2:08 PM, Jérôme Gardou wrote: > > And ReportFault would be "Your application crashed because of unexpected > > behaviour. Please report a bug to http://bugs.winehq.org. Don't forget to > > attach /tmp/wine.0.log. P

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Erich Hoover
On Sun, Feb 22, 2009 at 2:08 PM, Jérôme Gardou wrote: > Erich Hoover a écrit : > >> I know quite a few people (my converts) that run applications (mostly >> games) where they launch the application from an icon and there is no >> console. They've complained to me every once in a while that they w

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Jérôme Gardou
Erich Hoover a écrit : > I know quite a few people (my converts) that run applications (mostly > games) where they launch the application from an icon and there is no > console. They've complained to me every once in a while that they > would much prefer a dialog informed them when their applic

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Erich Hoover
On Sun, Feb 22, 2009 at 1:34 PM, Jérôme Gardou wrote: > ... > I'm not sure > that we want to reproduce windows XP behaviour here (understand "Your > application encountered an unexpected error. What do you want to do : > send report/do not send) which annoys most people, and is not that useful. >

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Jérôme Gardou
Chris Robinson a écrit : > On Sunday 22 February 2009 12:09:01 pm Austin English wrote: > >> On Sun, Feb 22, 2009 at 8:58 AM, Jérôme Gardou >> > wrote: > >>> Jérôme Gardou a écrit : >>> This should help debugging applications which performs their own exception handling

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Chris Robinson
On Sunday 22 February 2009 12:09:01 pm Austin English wrote: > On Sun, Feb 22, 2009 at 8:58 AM, Jérôme Gardou wrote: > > Jérôme Gardou a écrit : > >> This should help debugging applications which performs their own > >> exception handling. > > > > After a bit of thinking, I think that this should

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Austin English
On Sun, Feb 22, 2009 at 8:58 AM, Jérôme Gardou wrote: > Jérôme Gardou a écrit : >> This should help debugging applications which performs their own >> exception handling. > After a bit of thinking, I think that this should be displayed each time > the function is called. Is there any macro in wine

Re: faultrep:display useful information in ReportFault

2009-02-22 Thread Jérôme Gardou
Jérôme Gardou a écrit : > This should help debugging applications which performs their own > exception handling. After a bit of thinking, I think that this should be displayed each time the function is called. Is there any macro in wine/debug.h which would display a message, even when WINEDEBUG