Re: enhmfdrv: Return proper values from GDI APIs

2005-10-23 Thread Phil Krylov
On Fri, 21 Oct 2005 16:14:25 +0200 Alexandre Julliard <[EMAIL PROTECTED]> wrote: > I think it would be cleaner to simply fall through to the generic code > after calling the driver for these operations. Also there's no need to > add a FIXME on every single operation, this will cause a lot of noise

Re: enhmfdrv: Return proper values from GDI APIs

2005-10-21 Thread Alexandre Julliard
Phil Krylov <[EMAIL PROTECTED]> writes: > Are there any problems to apply this patch before 0.9? I think it would be cleaner to simply fall through to the generic code after calling the driver for these operations. Also there's no need to add a FIXME on every single operation, this will cause a l

Re: enhmfdrv: Return proper values from GDI APIs

2005-10-21 Thread Huw D M Davies
Writing some tests would probably help. Huw. On Fri, Oct 21, 2005 at 05:57:58PM +0400, Phil Krylov wrote: > Hi, > > Are there any problems to apply this patch before 0.9? > > On Mon, 17 Oct 2005 03:43:55 +0400 > Phil Krylov <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > This patch fixes EMF ren

Re: enhmfdrv: Return proper values from GDI APIs

2005-10-21 Thread Phil Krylov
Hi, Are there any problems to apply this patch before 0.9? On Mon, 17 Oct 2005 03:43:55 +0400 Phil Krylov <[EMAIL PROTECTED]> wrote: > Hi, > > This patch fixes EMF rendering in some programs that depend on the fact > that SetTextAlign(), SetBkMode(), SetROP2(), SetPolyFillMode(), and > SetStret