Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-06-21 Thread Vitaliy Margolen
Rob Shearman wrote: > 2008/6/21 Vitaliy Margolen <[EMAIL PROTECTED]>: >> @@ -300,6 +300,7 @@ static HRESULT >> DXDiag_InitDXDiagSystemInfoContainer(IDxDiagContainer* pSubCont) >>GlobalMemoryStatusEx( &msex ); >>V_VT(&v) = VT_UI8; >>V_UI8(&v) = msex.ullTotalPhys; >> + VariantChangeType

Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-06-21 Thread Rob Shearman
2008/6/21 Vitaliy Margolen <[EMAIL PROTECTED]>: > @@ -300,6 +300,7 @@ static HRESULT > DXDiag_InitDXDiagSystemInfoContainer(IDxDiagContainer* pSubCont) >GlobalMemoryStatusEx( &msex ); >V_VT(&v) = VT_UI8; >V_UI8(&v) = msex.ullTotalPhys; > + VariantChangeType(&v, &v, 0, VT_BSTR); >I

Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-05-31 Thread Vitaliy Margolen
Alexandre Julliard wrote: > Vitaliy Margolen <[EMAIL PROTECTED]> writes: > >> Well it really should be "%llu" but Wine doesn't support that. "%lu" >> is used btw at least in one place in the code: >> http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746 > > It's the correct format for a ULONG

Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-05-30 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Well it really should be "%llu" but Wine doesn't support that. "%lu" > is used btw at least in one place in the code: > http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746 It's the correct format for a ULONG_PTR. > What should it be then? The

Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-05-29 Thread Vitaliy Margolen
Alexandre Julliard wrote: > Vitaliy Margolen <[EMAIL PROTECTED]> writes: > >> Was anything wrong with this patch? I've used a simple utility >> DxDiagOutput.exe from DXSDK to find and test this. > > The printf format is wrong. > Well it really should be "%llu" but Wine doesn't support that. "%l

Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-05-29 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Was anything wrong with this patch? I've used a simple utility > DxDiagOutput.exe from DXSDK to find and test this. The printf format is wrong. -- Alexandre Julliard [EMAIL PROTECTED]

Re: dxdiagn: PhysicalMemory parameter is a string not long long

2008-05-29 Thread Vitaliy Margolen
Vitaliy Margolen wrote: > --- > dlls/dxdiagn/provider.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > Was anything wrong with this patch? I've used a simple utility DxDiagOutput.exe from DXSDK to find and test this. Vitaliy.