Re: dmband: Indirection levels fix

2008-02-21 Thread Andrew Talbot
Robert Shearman wrote: > This isn't correct. Judging by the surrounding code, this should be > allocating a block of memory of This->pDesc->pbMemData and then passing > pDesc->llMemLength into memcpy, possibly validating that > pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. >

Re: dmband: Indirection levels fix

2008-02-21 Thread Robert Shearman
Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI > IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ft