Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > The attached program produces the following output on my WinXP SP2: > > Loaded rsaenh.dll successfully! > Got CPAcquireContext address! > Success! Last error: Cool, thanks for taking the time to do this. I'll put the patch in. -- Alexandre Ju

Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Michael Jung
On Tuesday 09 November 2004 21:24, Alexandre Julliard wrote: > Michael Jung <[EMAIL PROTECTED]> writes: > > I agree that if this is done on Windows in advapi32, we have to do it > > there, too. What I meant to say was the following: > > > > There are basically two possibilities: > > 1.) It's done i

Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > I agree that if this is done on Windows in advapi32, we have to do it there, > too. What I meant to say was the following: > > There are basically two possibilities: > 1.) It's done in rsaenh. Then we are ok. > 2.) It's done in advapi32: Then it doesn'

Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Michael Jung
On Tuesday 09 November 2004 20:52, Alexandre Julliard wrote: > Michael Jung <[EMAIL PROTECTED]> writes: > > The test is in dlls/advapi32/tests/crypt.c, line 117. It passes at least > > on WinXP SP2. > > OK great, I missed that one. > > > What I don't know is if this should be set in > > advapi32/Cr

Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > The test is in dlls/advapi32/tests/crypt.c, line 117. It passes at least on > WinXP SP2. OK great, I missed that one. > What I don't know is if this should be set in > advapi32/CryptAcquireContext or in rsaenh/CPAcquireContext. However, setting > it

Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Michael Jung
On Tuesday 09 November 2004 20:21, Alexandre Julliard wrote: > Michael Jung <[EMAIL PROTECTED]> writes: > > Changelog: > > CPAcquireContext: Set last error to ERROR_SUCCESS in case of success. > > There are very few functions that set last error on success, do you > have a test demonstrating that

Re: dlls/rsaenh/rsaenh.c

2004-11-09 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > Changelog: > CPAcquireContext: Set last error to ERROR_SUCCESS in case of success. There are very few functions that set last error on success, do you have a test demonstrating that Windows does it in this case? -- Alexandre Julliard [EMAIL PROTECTED]