Re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Nikolay Sivov
On 3/23/2010 16:48, Eric Lanz wrote: Sure thing, The line we call is: m_pMD5XMLDoc->createNode(varType, L"md5report", L"",&pMD5RootNode); So it's not a BSTR. So I think we are sending the createNode function WCHAR strings like Nikolay is saying. For that call the SysStringLen function i

Re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Eric Lanz
Sure thing, The line we call is: m_pMD5XMLDoc->createNode(varType, L"md5report", L"", &pMD5RootNode); So I think we are sending the createNode function WCHAR strings like Nikolay is saying. For that call the SysStringLen function is giving a length of 0 for L"md5report". I think that Nikol

Re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Nikolay Sivov
On 3/23/2010 16:21, Dan Kegel wrote: Hi Eric, welcome to Wine! http://msdn.microsoft.com/en-us/library/ms221240.aspx says the only time those two functions disagree on valid bstr's is if there are embedded nul chars, in which case SysStringLength probably returns a larger value. Hi Dan. It's a

re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-23 Thread Dan Kegel
Hi Eric, welcome to Wine! http://msdn.microsoft.com/en-us/library/ms221240.aspx says the only time those two functions disagree on valid bstr's is if there are embedded nul chars, in which case SysStringLength probably returns a larger value. Are you quite, quite sure that your bstrs are valid? (I

Re: [PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-22 Thread Eric Lanz
Thank you, I will take a look at your changes, correct my work and re-submit. Eric On Mar 22, 2010, at 4:44 PM, Nikolay Sivov wrote: > On 3/22/2010 23:26, Eric Lanz wrote: >> Hello, >> >> Decided to keep it simple for my first patch. SysStringLen was returning 0 >> for bstrs from our updater

Re: [PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-22 Thread Nikolay Sivov
On 3/22/2010 23:26, Eric Lanz wrote: Hello, Decided to keep it simple for my first patch. SysStringLen was returning 0 for bstrs from our updater application which caused the domdoc_createNode function to exit early even though the bstr actually contained a valid name. It seems that other f

[PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length

2010-03-22 Thread Eric Lanz
Hello, Decided to keep it simple for my first patch. SysStringLen was returning 0 for bstrs from our updater application which caused the domdoc_createNode function to exit early even though the bstr actually contained a valid name. It seems that other functions in this file use strlenW for t