Re: dlls/kernel/process.c breakage due to environ

2003-10-10 Thread Gerald Pfeifer
On Fri, 10 Oct 2003, Alexandre Julliard wrote: >> Depending on how you plan to fix the compilation failure, it might make >> sense to have just one declaration at the top instead of several (and >> thus several #ifdef's, in case they are needed for the fix) in functions? > Well, maybe, but we can o

Re: dlls/kernel/process.c breakage due to environ

2003-10-10 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > Depending on how you plan to fix the compilation failure, it might make > sense to have just one declaration at the top instead of several (and > thus several #ifdef's, in case they are needed for the fix) in functions? Well, maybe, but we can only tel

Re: dlls/kernel/process.c breakage due to environ

2003-10-10 Thread Gerald Pfeifer
On Fri, 10 Oct 2003, Alexandre Julliard wrote: >> Declare environ at the top, not inside functions. > I must be missing something here. Why does this make a difference? I don't remember chapter and verse of the standards, but this came up some time ago on the GCC mailing lists (though, in hindsigh

Re: dlls/kernel/process.c breakage due to environ

2003-10-10 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > ChangeLog: > Declare environ at the top, not inside functions. I must be missing something here. Why does this make a difference? -- Alexandre Julliard [EMAIL PROTECTED]

dlls/kernel/process.c breakage due to environ

2003-10-10 Thread Gerald Pfeifer
My nightly autobuilder failed to build today, after I've had no problems for several days. This seems to be due to yesterday's changes in dlls/kernel: process.o: In function `build_initial_environment': wine/dlls/kernel/process.c:341: undefined reference to `environ' wine/dlls/kernel/proces