Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-05 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: OK, fair enough. Even though i did'nt like messing around with joystick_linuxinput.c i should have been smarter than trying to submit something i could not test... :-( But... tada!... now i have re-fixed it and re-tested both implementations. Its seems stable now. :-)

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Peter Dons Tychsen
On Fri, 2007-08-03 at 01:02 +0200, Peter Dons Tychsen wrote: > On Thu, 2007-08-02 at 06:54 -0600, Vitaliy Margolen wrote: > > Peter Dons Tychsen wrote: > > > On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: > > >> Peter Dons Tychsen wrote: > > >>> On Tue, 2007-07-31 at 06:34 -0600, Vitali

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Peter Dons Tychsen
On Thu, 2007-08-02 at 06:54 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: > >> Peter Dons Tychsen wrote: > >>> On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > On Mon, 2007

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Christoph Frick
On Thu, Aug 02, 2007 at 06:54:12AM -0600, Vitaliy Margolen wrote: > >OK, so how do i force my system to use the other implementation (so i > >can test it) ? > >I have a Logitech WingMan Extreme (old version). > Just (re)move /dev/input/js*. Or in dinput change device name to point to > non-existe

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 17:43 -0600,

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-01 Thread Peter Dons Tychsen
On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: > >> Peter Dons Tychsen wrote: > >>> On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: > On Sun, 2007-07-29 at 17:43 -0600, Vitaliy M

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-31 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: OK. Please review this diff: I wil

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-31 Thread Peter Dons Tychsen
On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: > >> On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: > >>> Peter Dons Tychsen wrote: > OK. Please review this diff: > > I

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-31 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: OK. Please review this diff: I will re-submit it if you like it. /Pedro Alright looks good now (you might want to remove

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-30 Thread Peter Dons Tychsen
On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: > On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: > > Peter Dons Tychsen wrote: > > > OK. Please review this diff: > > > > > > I will re-submit it if you like it. > > > > > > /Pedro > > > > Alright looks good now (you might

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-30 Thread Peter Dons Tychsen
On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > OK. Please review this diff: > > > > I will re-submit it if you like it. > > > > /Pedro > > Alright looks good now (you might want to remove the extra white space your > patch adds - git complains about t

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-29 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: OK. Please review this diff: I will re-submit it if you like it. /Pedro Alright looks good now (you might want to remove the extra white space your patch adds - git complains about those). Just left to make the same change to the other joystick interface :) BTW d

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-29 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 13:40 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 11:15 -0600, Vitaliy Margolen wrote: I have re-sent the patch with all your remarks fixed, except for the one regarding joystick_linuxinput.c, which cannot be

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-29 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 11:15 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: Hello again Wine! Here is a small fix for dinput which fixes application which call CreateDevice with the standard Joystick GUID instead of the GUID supplied in the enumeration callba

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-29 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: Hello again Wine! Here is a small fix for dinput which fixes application which call CreateDevice with the standard Joystick GUID instead of the GUID supplied in the enumeration callback. The patch looks good, and I see what you trying to fix. It would be nice if you