Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-16 Thread Vitaliy Margolen
Sergey Khodych wrote: >> No, there are 2 separate implementations - one ascii another unicode. During >> the object creation one would specify either ascii or unicode RIID. > > Objects IDirectInputDevice8W and IDirectInputDevice8A has function > GetProperty. This function get struct of type DIPRO

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-16 Thread Sergey Khodych
> No, there are 2 separate implementations - one ascii another unicode. During > the object creation one would specify either ascii or unicode RIID. Objects IDirectInputDevice8W and IDirectInputDevice8A has function GetProperty. This function get struct of type DIPROPSTRING as input/output parame

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-15 Thread Vitaliy Margolen
Sergey Khodych wrote: >> In ascii function you are calling unicode function and copying it's output >> (unicode string) to the ascii string buffer. This is wrong. Also because >> these functions deal with strings you have to implement both ascii and >> unicode functions at the same time. You can

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-15 Thread Sergey Khodych
> In ascii function you are calling unicode function and copying it's output > (unicode string) to the ascii string buffer. This is wrong. Also because > these functions deal with strings you have to implement both ascii and > unicode functions at the same time. You can't forward one to the othe

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-14 Thread Vitaliy Margolen
Sergey Khodych wrote: >>> ... >>> +hr = SysKeyboardWImpl_GetObjectInfo( >>> (LPDIRECTINPUTDEVICE8W)iface , &didoi, >>> + ps->diph.dwObj, >>> ps->diph.dwHow ); >> You mixing unicode and ascii. Also if you are implementing >> SysK

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-14 Thread Sergey Khodych
> >> ... >> +hr = SysKeyboardWImpl_GetObjectInfo( >> (LPDIRECTINPUTDEVICE8W)iface , &didoi, >> + ps->diph.dwObj, >> ps->diph.dwHow ); > > You mixing unicode and ascii. Also if you are implementing > SysKeyboardAImpl_GetPropert

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device

2008-04-13 Thread Vitaliy Margolen
Sergey Khodych wrote: > > > > > > +static HRESULT WINAPI SysKeyboardAImpl_GetProperty( > ... > +if (TRACE_ON(dinput)) > +_dump_DIPROPHEADER(pdiph); Please drop the TRACE_ON check - it's being done in dump func