Re: dib fixes

2005-04-13 Thread Rein Klazes
On 13 Apr 2005 17:11:57 +0200, you wrote: > Rein Klazes <[EMAIL PROTECTED]> writes: > > > --- wine/dlls/x11drv/dib.c 2005-04-13 08:55:39.0 +0200 > > +++ mywine/dlls/x11drv/dib.c2005-04-13 13:24:10.0 +0200 > > @@ -3484,6 +3484,41 @@ static void X11DRV_DIB_GetImageBits_32(

Re: dib fixes

2005-04-13 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > --- wine/dlls/x11drv/dib.c2005-04-13 08:55:39.0 +0200 > +++ mywine/dlls/x11drv/dib.c 2005-04-13 13:24:10.0 +0200 > @@ -3484,6 +3484,41 @@ static void X11DRV_DIB_GetImageBits_32( > } > } > > +static int XGetSubImageErrorHandler

Re: dib fixes

2005-04-13 Thread Rein Klazes
On 13 Apr 2005 11:59:02 +0200, you wrote: > > > > What am I doing wrong here? > > Nothing, there's no way to avoid the race. You just need to ignore the > BadMatch error in that case. Right, here is the next try: Changelog: dlls/x11drv : dib.c In X11DRV_DIB_SetImageBits avoid BadMatch err

Re: dib fixes

2005-04-13 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > As soon as I move the window to which I am calling SetDIBitsToDevice > partly outside of the screen, the drawable lies partly outside the > screen rectangle and XGetSubImage fails -> crash. > Clipping to the screen rectangle helps somewhat for very slow m

Re: dib fixes

2005-04-12 Thread Rein Klazes
On 11 Apr 2005 17:48:58 +0200, you wrote: > Rein Klazes <[EMAIL PROTECTED]> writes: > > > I tried to do this, you need to clip to the visible region as well. I > > could not get it 100% full proof because of races between the clip > > calculations and the actual positions on the screen. > > > >

Re: dib fixes

2005-04-11 Thread Alexandre Julliard
Rein Klazes <[EMAIL PROTECTED]> writes: > I tried to do this, you need to clip to the visible region as well. I > could not get it 100% full proof because of races between the clip > calculations and the actual positions on the screen. > > So I get the pixels now from the root window (clipped to

Re: dib fixes

2005-04-11 Thread Rein Klazes
On Sat, 09 Apr 2005 10:19:36 +0200, you wrote: > > Are you suggesting more checks then that the pixels are within the > > dimensions of the drawable? > you need at least to use the intersection of the bitmap and the drawable (not > sure both start at (0,0) corner though). I tried to do this, you

Re: dib fixes

2005-04-09 Thread Eric Pouech
Are you suggesting more checks then that the pixels are within the dimensions of the drawable? you need at least to use the intersection of the bitmap and the drawable (not sure both start at (0,0) corner though). I was also wondering what would happen when stretching is required, but IIRC this i

Re: dib fixes

2005-04-08 Thread Rein Klazes
On Sat, 09 Apr 2005 07:15:43 +0200, you wrote: > > I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a > > patch from you. The patch (attached) is only 5 years old, I am sure you > > remember all the details ;) > sure... since RLE encoding can have holes (ie, it can jump a coup

Re: dib fixes

2005-04-08 Thread Eric Pouech
Rein Klazes a écrit : Hi Eric, I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a patch from you. The patch (attached) is only 5 years old, I am sure you remember all the details ;) sure... since RLE encoding can have holes (ie, it can jump a couple of pixels or lines ahead), w

Re: dib fixes

2005-04-08 Thread Rein Klazes
Hi Eric, I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a patch from you. The patch (attached) is only 5 years old, I am sure you remember all the details ;) To be precise, I get X-errors in the calls to XGetSubImage caused by out of range parameters. Fixing this by some par