Re: [PATCH] devenum: Do not fail with a IBindCtx (with tests)

2012-05-15 Thread Dmitry Timoshkov
Detlef Riekenberg wrote: > static HRESULT WINAPI DEVENUM_IMediaCatMoniker_BindToStorage(IMoniker > *iface, IBindCtx *pbc, > IMoniker *pmkToLeft, REFIID riid, void **ppvObj) > { > +static IBindCtx *old_bc; > MediaCatMoniker *This = impl_from_IMoniker(iface); > > TRACE("

Re: [PATCH] devenum: Add tests for devenum. (try 2)

2012-03-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17512 Your paranoid android

Re: [PATCH] devenum: Add tests for devenum.

2012-03-27 Thread Marvin
anoid android. === WNT4WSSP6 (32 bit devenum) === devenum.c:59: Test failed: Cannot create CLSID_SystemDeviceEnum object (res = 80040154)

New winetricks 20100917: new verbs crypt32, devenum, d3dx9_26, winhttp

2010-09-17 Thread Dan Kegel
Another fortnight, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: crypt32: added (Issue 162). devenum: added (Issue 163). divx: update sha1sum

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread Chris Robinson
On Wednesday 10 September 2008 01:52:02 pm David Laight wrote: > On Wed, Sep 10, 2008 at 01:38:03PM -0700, Juan Lang wrote: > > Why use two parentheses when 6 will do, eh? Sorry, I don't agree that > > this is clearer. > > Agreed, if you add too many parenthesis it gets difficult to see > where th

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread David Laight
On Wed, Sep 10, 2008 at 01:38:03PM -0700, Juan Lang wrote: > > I'm pretty sure this would come out as: > > dwMediaTypeSize + (dwMediaTypeSize < (2 ? 1 : dwMediaTypeSize) / 2) > > It doesn't, check the order of operations again. > > > But even if it doesn't, I don't think it'd hurt to be more expl

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread Juan Lang
> I'm pretty sure this would come out as: > dwMediaTypeSize + (dwMediaTypeSize < (2 ? 1 : dwMediaTypeSize) / 2) It doesn't, check the order of operations again. > But even if it doesn't, I don't think it'd hurt to be more explicit: > dwMediaTypeSize + ((dwMediaTypeSize < 2) ? 1 : (dwMediaTypeSize

Re: devenum: Fix order of operations bug (Coverity id 709)

2008-09-10 Thread Chris Robinson
On Wednesday 10 September 2008 11:34:03 am Juan Lang wrote: > dwMediaTypeSize + (dwMediaTypeSize < 2 ? 1 : dwMediaTypeSize / 2) I'm pretty sure this would come out as: dwMediaTypeSize + (dwMediaTypeSize < (2 ? 1 : dwMediaTypeSize) / 2) But even if it doesn't, I don't think it'd hurt to be more ex

Re: devenum: Constify a variable

2007-04-22 Thread Robert Shearman
Andrew Talbot wrote: Robert Shearman wrote: Andrew Talbot wrote: */ static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( LPCLASSFACTORY iface, -LPUNKNOWN pUnkOuter, +const IUnknown *pUnkOuter, REFIID riid, LPVOID *ppvObj) I'm not sure what th

Re: devenum: Constify a variable

2007-04-22 Thread Andrew Talbot
Robert Shearman wrote: > Andrew Talbot wrote: >> */ >> static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( >> LPCLASSFACTORY iface, >> -LPUNKNOWN pUnkOuter, >> +const IUnknown *pUnkOuter, >> REFIID riid, >> LPVOID *ppvObj) >> > > I'm not sure what the point of

Re: devenum: Constify a variable

2007-04-22 Thread Robert Shearman
Andrew Talbot wrote: */ static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( LPCLASSFACTORY iface, -LPUNKNOWN pUnkOuter, +const IUnknown *pUnkOuter, REFIID riid, LPVOID *ppvObj) I'm not sure what the point of this is. -- Rob Shearman

Re: devenum: Cleanup the formatting of register_clsids to match 4-space indention of the rest of the file

2006-07-03 Thread James Hawkins
On 7/3/06, James Hawkins <[EMAIL PROTECTED]> wrote: Changelog: * Cleanup the formatting of register_clsids to match 4-space indention of the rest of the file. * Initialize hkeys to avoid calling RegCloseKey on an uninitialized value. Ignore this patch, it doesn't even compile :-\ -- James Ha

Re: Localization of devenum and minor corrections

2004-07-26 Thread Marcelo Duarte
Resend. Changelog: Marcelo Duarte <[EMAIL PROTECTED]> Localization to Portuguese (devenum) and minor corrections (winmm, progman, winmine). Index: dlls/devenum/devenum.rc === RCS file: /home/wine/wine/dlls/devenum/devenu

Re: devenum

2004-07-23 Thread Ivan Leo Puoti
> Why you do not leave the neutral resources in the main archive? That's how it's done in other files, anyway, I'll send another patch that leaves the neutral resources in the main file. Ivan.

Re: devenum

2004-07-22 Thread Marcelo Duarte
Ivan Leo Puoti wrote: English resources moved to En.rc, language neutral resources moved to Xx.rc, and italian resources added in It.rc Licence: LGPL Ivan. Ivan, Why you do not leave the neutral resources in the main archive? Greetings, Marcelo