Re: dead stores in msxml3

2008-11-18 Thread Piotr Caban
Hi Ricardo, There are few things that needs to be changed in 'dlls/msxml3: check dead stores (llvm/clang)' patch. Some of the 'hr != S_OK' should not be replaced with 'FAILED(hr)'. Sometimes the parser should stop if user returns anything except S_OK. Changes in following functions are incorrec

dead stores in msxml3

2008-11-18 Thread ricardo filipe
hi leslie. i'm tracking some dead stores with Clang and there are some in dlls/msxml3/saxreader.c i'm hoping you can tell me if the stores are to be removed for performance or if they should be checked in each iteration for correctness: file dlls/msxml3/saxreader.c lines: 1163 1166 1213 1216 re