Re: ddraw correctness fixes patch

2005-03-20 Thread Matthew Mastracci
Christian Costa wrote: I think the problem Matthew was talking is how to remap surface pointers. I sent something to Mattew but I forgot to cc wine-devel, sorry. Basically it was : depth = surface_desc.u4.ddpfPixelFormat.u1.dwRGBBitCount; ddesc.lpSurface -= (lock_dst.left - lock_union.left)*(depth+

Re: ddraw correctness fixes patch

2005-03-18 Thread Christian Costa
Tony Lambregts wrote: Matthew Mastracci wrote: Thanks for the review - comments inline. Christian Costa wrote: The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize

Re: ddraw correctness fixes patch

2005-03-18 Thread Tony Lambregts
Matthew Mastracci wrote: Thanks for the review - comments inline. Christian Costa wrote: The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize = sizeof(ddesc); if (s

Re: ddraw correctness fixes patch

2005-03-18 Thread Matthew Mastracci
Thanks for the review - comments inline. Christian Costa wrote: The new locking mechanism is wrong. DDLOCK_xxx are just used for optimization. The thing to do during the blit should be something like that : sdesc.dwSize = sizeof(sdesc); ddesc.dwSize = sizeof(ddesc); if (src == NULL) IDirectDrawSu

Re: ddraw correctness fixes patch

2005-03-18 Thread Christian Costa
> Message du 18/03/05 13:49 > De : "Christian Costa" > A : "Tom Wickline" , "wine-devel" > Copie à : > Objet : Re: ddraw correctness fixes patch > > > > Message du 18/03/05 06:44 > > De : "Tom Wickline" >

Re: ddraw correctness fixes patch

2005-03-18 Thread Christian Costa
> Message du 18/03/05 06:44 > De : "Tom Wickline" > A : "wine-devel" > Copie à : > Objet : ddraw correctness fixes patch > > anyone know why this patch hasn't been accepted? > > http://www.winehq.org/hypermail/wine-patches/2005/03/0328.ht

ddraw correctness fixes patch

2005-03-17 Thread Tom Wickline
anyone know why this patch hasn't been accepted? http://www.winehq.org/hypermail/wine-patches/2005/03/0328.html Tom