Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-15 Thread Stefan Dösinger
Am Montag, 14. Mai 2012, 18:45:01 schrieb paulo lesgaz: > But I can write a small test. Would writing a test attaching an offscreen surface to another offscreen surface be enough to convince you of the correctness of the change? I recommend to port the entire AttachmentTest from dlls/ddraw/tests/

Re : ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-14 Thread paulo lesgaz
+ David De : Stefan Dösinger À : wine-devel@winehq.org Envoyé le : Lundi 14 mai 2012 16h53 Objet : Re: ddraw: Forward AddAttachedSurface to the correct equivalent Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: > +   

Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-14 Thread Matteo Bruni
2012/5/14 Stefan Dösinger : > Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: >> +    hr = ddraw_surface3_AddAttachedSurface(&This- >>IDirectDrawSurface3_iface, >> +            attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : > NULL); > It isn't immediately clear to me why Sur

Re: ddraw: Forward AddAttachedSurface to the correct equivalent

2012-05-14 Thread Stefan Dösinger
Am Sonntag, 13. Mai 2012, 20:39:27 schrieb David Adam: > +hr = ddraw_surface3_AddAttachedSurface(&This- >IDirectDrawSurface3_iface, > +attachment_impl ? &attachment_impl->IDirectDrawSurface3_iface : NULL); It isn't immediately clear to me why Surface3 is correct instead of Surface7