Re: [RESEND] ddraw: Fix refcounting of palettes

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 17:43:52 schrieb Cihan Altinay: > Changed as suggested by Stefan Dösinger. Looks good to me

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Alexander Dorofeyev
Stefan Dösinger wrote: > Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: >> This fixes a crash in a game called "Autobahnverfolgungsjagd Total" >> (not in AppDB). > I think it would be better to set pal = NULL if there is no wined3d palette > returned a few lines above the place you'

[RESEND] ddraw: Fix refcounting of palettes

2008-03-16 Thread Cihan Altinay
40:29 +0100 Subject: ddraw: Fix refcounting of palettes when loading textures --- dlls/ddraw/texture.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/dlls/ddraw/texture.c b/dlls/ddraw/texture.c index 8835e4e..1541237 100644 --- a/dlls/ddraw/texture.c +++ b/d

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 17:22:52 schrieb Cihan Altinay: > Stefan Dösinger wrote: > > Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: > > I think it would be better to set pal = NULL if there is no wined3d > > palette returned a few lines above the place you're changing. > > That's f

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Cihan Altinay
Stefan Dösinger wrote: > Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: > I think it would be better to set pal = NULL if there is no wined3d palette > returned a few lines above the place you're changing. That's fine with me but it would mean setting it to NULL in every iteration

Re: ddraw: Fix refcounting of palettes

2008-03-16 Thread Stefan Dösinger
Am Sonntag, 16. März 2008 14:44:37 schrieb [EMAIL PROTECTED]: > This fixes a crash in a game called "Autobahnverfolgungsjagd Total" > (not in AppDB). I think it would be better to set pal = NULL if there is no wined3d palette returned a few lines above the place you're changing. > While tracing t

ddraw: Fix refcounting of palettes

2008-03-16 Thread bobbyg
9dc135737 Mon Sep 17 00:00:00 2001 From: Cihan Altinay <[EMAIL PROTECTED]> Date: Sun, 16 Mar 2008 14:25:27 +0100 Subject: ddraw: Fix refcounting of palettes This patch prevents releasing the same palettes more than once if main surfaces have a palette while sub-surfaces haven't. --- dll