Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-05-10 Thread Stefan Dösinger
>> Please add an additional test that passes in non-null flags that >don't match >> standard R5G6B5. > >I'm not exactly sure what you mean with this. The other test has mask >of >R5G5B5. The one that's missing is R5G6B5, but I don't think it's >needed. E.g. a red mask of 0xf0f0, green 0x0f00 and

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-05-10 Thread Ričardas Barkauskas
On 05/09/2011 10:11 PM, Stefan Dösinger wrote: > On Monday 09 May 2011 20:55:21 Ričardas Barkauskas wrote: >> +modes16bpp_cnt = 0; >> +U2(ddsd.ddpfPixelFormat).dwRBitMask = 0x; >> +U3(ddsd.ddpfPixelFormat).dwGBitMask = 0x; >> +U4(ddsd.ddpfPixelFormat).dwBBitMask = 0x; >

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-05-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10820 Your paranoid android

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-05-09 Thread Stefan Dösinger
On Monday 09 May 2011 20:55:21 Ričardas Barkauskas wrote: > +modes16bpp_cnt = 0; > +U2(ddsd.ddpfPixelFormat).dwRBitMask = 0x; > +U3(ddsd.ddpfPixelFormat).dwGBitMask = 0x; > +U4(ddsd.ddpfPixelFormat).dwBBitMask = 0x; Please add an additional test that passes in non-null f

Re: ddraw: Fix filtering of enumerated display modes by bits per pixel

2011-04-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10648 Your paranoid android