Yes, it is exactly that. So, I wonder why the patches were not committed.
David
2008/6/11 Stefan Dösinger <[EMAIL PROTECTED]>:
> > So why are you adding the check that is not present on windows? What
> > are th
> > reasoning to have this if it clearly absent in native implementation?
> As I unde
devel
Subject: Re: ddraw: Fix Setmaterial with a test
Yes, it is exactly that. So, I wonder why the patches were not committed.
> So why are you adding the check that is not present on windows? What
> are th
> reasoning to have this if it clearly absent in native implementation?
As I understand it, native ddraw.dll(d3d7) has the check, while d3d8/d3d9 do
not. Thus he removed it from WineD3D to have the same behavior as nati
David Adam wrote:
> I sent a patch to removed these test earlier.
>
>
> So why are you adding the check that is not present on windows? What
> are th reasoning to have this if it clearly absent in native
> implementation?
>
>
> That's why I removed it form wined3d. I set the check i
I sent a patch to removed these test earlier.
>
>> So why are you adding the check that is not present on windows? What are
> th reasoning to have this if it clearly absent in native implementation?
That's why I removed it form wined3d. I set the check in ddraw, since only
ddraw checks it.
Dav
David Adam wrote:
>>David Adam wrote:
>>>/ The test succeded in my windows XP box.
> />>/
> />You have only ddraw test and no d3d test.
>>
>>Vitaliy.
>
> Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes.
>
> It is a forbidden value (see bug 13646). So, no test can be per
>David Adam wrote:
>>* The test succeded in my windows XP box.
*>>*
*>You have only ddraw test and no d3d test.
>
>Vitaliy.
Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes.
It is a forbidden value (see bug 13646). So, no test can be performed
for d3d8 and d3d9.
I sent a p
David Adam wrote:
> The test succeded in my windows XP box.
>
You have only ddraw test and no d3d test.
Vitaliy.
