Re: ddraw: Assign to structs instead of using memcpy

2008-02-19 Thread Andrew Talbot
Stefan Dösinger wrote: > Am Sonntag, 17. Februar 2008 01:38:50 schrieb Andrew Talbot: >> And I presume that if the underlying struct tags >> are different between two similar types, then the compiler would warn of >> type incompatibility if such an assignment were attempted. > Not quite. You can h

Re: ddraw: Assign to structs instead of using memcpy

2008-02-19 Thread Stefan Dösinger
Am Sonntag, 17. Februar 2008 01:38:50 schrieb Andrew Talbot: > And I presume that if the underlying struct tags > are different between two similar types, then the compiler would warn of > type incompatibility if such an assignment were attempted. Not quite. You can have a DDSURFACEDESC2 *ddsd poi

Re: ddraw: Assign to structs instead of using memcpy

2008-02-16 Thread Andrew Talbot
Stefan Dösinger wrote: > Am Samstag, 16. Februar 2008 23:33:37 schrieb Andrew Talbot: >> Here, I am assuming that the "dwSize" elements in all these cases should >> be set to the size of the struct each is in, respectively. Please advise >> if this assumption is wrong. > It's not necessarily true.

Re: ddraw: Assign to structs instead of using memcpy

2008-02-16 Thread Stefan Dösinger
der structures(in some cases we may need more tests) > Thanks, > > -- Andy. > --- > Changelog: > ddraw: Assign to structs instead of using memcpy. > > diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c > index b60b6f3..03ccea8 100644 > --- a/dlls/dd