Re: dbghelp: Implement rudimentary stack walk for ARM64

2013-01-22 Thread André Hentschel
Am 22.01.2013 20:26, schrieb Eric Pouech: > Le 21/01/2013 20:26, André Hentschel a écrit : >> Am 21.01.2013 10:50, schrieb Eric Pouech: +if ((frame->AddrPC.Mode == AddrModeFlat) && +(frame->AddrFrame.Mode != AddrModeFlat)) >>> this looks strange to me. >>> I guess, you

Re: dbghelp: Implement rudimentary stack walk for ARM64

2013-01-22 Thread Eric Pouech
Le 21/01/2013 20:26, André Hentschel a écrit : Am 21.01.2013 10:50, schrieb Eric Pouech: +if ((frame->AddrPC.Mode == AddrModeFlat) && +(frame->AddrFrame.Mode != AddrModeFlat)) this looks strange to me. I guess, you want to check that both mode address modes are AddrModeFlat

Re: dbghelp: Implement rudimentary stack walk for ARM64

2013-01-21 Thread André Hentschel
Am 21.01.2013 10:50, schrieb Eric Pouech: >> +if ((frame->AddrPC.Mode == AddrModeFlat) && >> +(frame->AddrFrame.Mode != AddrModeFlat)) > this looks strange to me. > I guess, you want to check that both mode address modes are AddrModeFlat > A+ > it's the same as for the other a

Re: dbghelp: Implement rudimentary stack walk for ARM64

2013-01-21 Thread Eric Pouech
> +if ((frame->AddrPC.Mode == AddrModeFlat) && > +(frame->AddrFrame.Mode != AddrModeFlat)) this looks strange to me. I guess, you want to check that both mode address modes are AddrModeFlat A+ -- Eric Pouech