Re: d3dx9_36 [patch 2/2]: Add tests for D3DXCreateBox

2011/3/31 Matteo Bruni > 2011/3/31 David Adam : > > > > > > 2011/3/31 Matteo Bruni > >> > >> 2011/3/31 David Adam : > >> > > >> > + /* Check the width */ > >> > +v1 = *((D3DXVECTOR3*)(data+19*num_bytes_per_vertex)); > >> > +v2 = *((D3DXVECTOR3*)(data+18*num_bytes_per_vertex)

Re: d3dx9_36 [patch 2/2]: Add tests for D3DXCreateBox

2011/3/31 Matteo Bruni > 2011/3/31 David Adam : > > > > + /* Check the width */ > > +v1 = *((D3DXVECTOR3*)(data+19*num_bytes_per_vertex)); > > +v2 = *((D3DXVECTOR3*)(data+18*num_bytes_per_vertex)); > > +length = D3DXVec3Length(D3DXVec3Subtract(&v2,&v1,&v2)); > > +

Re: d3dx9_36 [patch 2/2]: Add tests for D3DXCreateBox

2011/3/31 David Adam : > > > 2011/3/31 Matteo Bruni >> >> 2011/3/31 David Adam : >> > >> > +      /* Check the width */ >> > +        v1 = *((D3DXVECTOR3*)(data+19*num_bytes_per_vertex)); >> > +        v2 = *((D3DXVECTOR3*)(data+18*num_bytes_per_vertex)); >> > +        length = D3DXVec3Length(D3DX

Re: d3dx9_36 [patch 2/2]: Add tests for D3DXCreateBox

2011/3/31 David Adam : > > + /* Check the width */ > +v1 = *((D3DXVECTOR3*)(data+19*num_bytes_per_vertex)); > +v2 = *((D3DXVECTOR3*)(data+18*num_bytes_per_vertex)); > +length = D3DXVec3Length(D3DXVec3Subtract(&v2,&v1,&v2)); > +ok(fabs(length-10.0f) received %f\n

Re: d3dx9_36: Implement D3DXCreateBox

On 03/27/2011 04:52 PM, Joshua Beck wrote: > On a side note, you could rearrange this loop to use less multiplications: > +for(i = 0; i< 24; i++) > +{ > +int sixi = 6 * i; > +vertices[sixi] *= width; > +vertices[sixi + 1] *= height; > +vertices[sixi + 2]

Re: d3dx9_36: Implement D3DXCreateBox

Joshua Beck wrote: > >> Or even better: > >> +for(i = 0; i< 144; i+=4) > >> +{ > >> +vertices[i ] *= width; > >> +vertices[++i] *= height; > >> +vertices[++i] *= depth; > >> +} > >> > > There shouild be i + 1 and i + 2 instead of two ++i otherwise > >

Re: d3dx9_36: Implement D3DXCreateBox

On 03/27/2011 10:58 PM, Dmitry Timoshkov wrote: Joshua Beck wrote: Or even better: +for(i = 0; i< 144; i+=4) +{ +vertices[i ] *= width; +vertices[++i] *= height; +vertices[++i] *= depth; +} There shouild be i + 1 and i + 2 instead of two ++i ot

Re: d3dx9_36: Implement D3DXCreateBox

Joshua Beck wrote: > Or even better: > +for(i = 0; i< 144; i+=4) > +{ > +vertices[i ] *= width; > +vertices[++i] *= height; > +vertices[++i] *= depth; > +} There shouild be i + 1 and i + 2 instead of two ++i otherwise the loop index gets corrupted. -- Dmit

Re: d3dx9_36: Implement D3DXCreateBox

On 3/27/2011 11:08 AM, Joris Huizer wrote: But you are changing the values during the function: + +for(i = 0; i< 24; i++) +{ +vertices[6 * i] *= width; +vertices[6 * i + 1] *= height; +vertices[6 * i + 2] *= depth; +} + On a side note, you could rearran

Re: d3dx9_36: Implement D3DXCreateBox

Hello, In this patch, one part seemed strange to me: You are declaring vertices as static memory: +static FLOAT vertices[144] But you are changing the values during the function: + +for(i = 0; i< 24; i++) +{ +vertices[6 * i] *= width; +vertices[6 * i + 1] *= he

Re: d3dx9_36 [try 3]: Add a few tests for D3DXCreateBox

Most of the objections from the previous try still stand: check your whitespaces (whitespace after every comma, whitespaces around operators, whitespace after "if" or "for" keywords), you have to be consistent. Comparing indices doesn't make much sense now that you don't check vertices, I think you

Re: d3dxcreatebox patch

2011/3/10 Alexandre Julliard > Matteo Bruni writes: > > > 2011/3/10 David Adam : > >> Thanks for the feedback. What do you mean by "you are forcing a > particular > >> vertex ordering3"? > > > > I mean that you are testing the vertices

Re: d3dxcreatebox patch

Matteo Bruni writes: > 2011/3/10 David Adam : >> Thanks for the feedback. What do you mean by "you are forcing a particular >> vertex ordering3"? > > I mean that you are testing the vertices of the mesh returned by > D3DXCreateBox in the order generated by n

Re: d3dxcreatebox patch

Thanks for the feedback. What do you mean by "you are forcing a particular vertex ordering3"? I just test the vertex that D3DXCreateBox sent. I think it is not possible to choose the ordering of the vertices for D3DXCreateBox. Did I miss anything? A+ David 2011/3/9 Matteo Bruni

Re: d3dxcreatebox patch

2011/3/10 David Adam : > Thanks for the feedback. What do you mean by "you are forcing a particular > vertex ordering3"? I mean that you are testing the vertices of the mesh returned by D3DXCreateBox in the order generated by native d3dx9, while they could in general be in any o

Re: d3dxcreatebox patch

2011/3/9 David Adam : > Hello, > > is there any problem with my d3dxcreatebox patch? > > Thanks in advance for any feedback. > > A+ > > David > Do you refer to http://source.winehq.org/patches/data/71983 ? I just had a cursory look at it: I presume there isn't

d3dxcreatebox patch

Hello, is there any problem with my d3dxcreatebox patch? Thanks in advance for any feedback. A+ David

Re: d3dx9_36 [patch 1/3, resend]: Add tests for D3DXCreateBox

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9719 Your paranoid android.

d3dx9_36 [resend]: Add a few tests for D3DXCreateBox

Hello, no feedback available for this patch? It was rejected silently. A+ David -- Forwarded message -- From: David Adam Date: 2011/2/9 Subject: d3dx9_36 [resend]: Add a few tests for D3DXCreateBox To: wine-patches Fixed following Stefan's advices. A+ David

Re: d3dx9_36: Implement a few tests for D3DXCreateBox

Am Mittwoch 09 Februar 2011, 07:34:21 schrieb David Adam: > +wnd = CreateWindow("static", "d3dx9_test", 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL); The class "static" doesn't work on Windows 7, I am afraid you'll need a proper window class. And I think a CreateWindow failure should count as test

Re: d3dx9_36 [patch 1/2, resend]: Implement D3DXCreateBox

On 28 December 2010 11:25, David Adam wrote: > > -HRESULT WINAPI D3DXCreateBox(LPDIRECT3DDEVICE9 device, FLOAT width, FLOAT > height, > - FLOAT depth, LPD3DXMESH* mesh, LPD3DXBUFFER*

Re: d3dxcreatebox

Am Freitag 24 Dezember 2010, 12:43:30 schrieb David Adam: > Hello, > > is there any problem with the patch for D3DXCreateBox? > I think it was not commited. I guess I should have reviewed it, but didn't :-/ Anyway, here is what I found: * There are some whitespace issues, lik

d3dxcreatebox

Hello, is there any problem with the patch for D3DXCreateBox? I think it was not commited. Thanks in advance for any feedback? A+ David

Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)

On 17 July 2010 21:14, Misha Koshelev wrote: > @@ -636,6 +636,10 @@ static void D3DXCreateBoxTest(void) >             IDirect3DVertexBuffer9_Release(vertex_buffer); >         } > > +        /* Index buffer */ > +        number_of_faces = box->lpVtbl->GetNumFaces(box); > +        todo_wine ok( numb

Re: [PATCH 04/10] d3dx9: Add tests for D3DXCreateBox. (try 2)

Same comments apply as for the previous patches. With this being a larger dataset it makes even more sense to calculate the vertices instead of hardcoding them.

Re: [PATCH 09/10] d3dx9: Implement D3DXCreateBox for the case of incorrect parameters. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3425 Your paranoid android.

Re: [PATCH 07/10] d3dx9: Add tests for D3DXCreateBox index buffer description. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3423 Your paranoid android.

Re: [PATCH 10/10] d3dx9: Add basic test for D3DXCreateBox vertex buffer declaration. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3426 Your paranoid android.

Re: [PATCH 08/10] d3dx9: Add NULL mesh parameter test to D3DXCreateBox. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3424 Your paranoid android.

Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3422 Your paranoid android.

Re: [PATCH 04/10] d3dx9: Add tests for D3DXCreateBox. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3420 Your paranoid android.

Re: [PATCH 09/10] d3dx9: Implement D3DXCreateBox for the case of incorrect parameters.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3365 Your paranoid android.

Re: [PATCH 08/10] d3dx9: Add tests for D3DXCreateBox index buffer description.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3364 Your paranoid android.

Re: [PATCH 10/10] d3dx9: Add NULL mesh parameter test to D3DXCreateBox.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3366 Your paranoid android.

Re: [PATCH 07/10] d3dx9: Add test for number of faces in D3DXCreateBox.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3363 Your paranoid android.

Re: [PATCH 05/10] d3dx9: Add tests for D3DXCreateBox.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3361 Your paranoid android.