Re: d3dx8: Implement D3DXBoxBoundProbe

2008-07-30 Thread H. Verbeet
2008/7/30 David Adam <[EMAIL PROTECTED]>: > I forgot to add a change recommended by Henri. > Now, everything should be fine. > Oops, missed that myself as well :-)

Re: d3dx8: Implement D3DXBoxBoundProbe

2008-07-30 Thread H. Verbeet
Looks ok to me.

Re: d3dx8: Implement D3DXBoxBoundProbe

2008-07-30 Thread H. Verbeet
Looks good in principle, but I've still got a few comments: > +if ( praydirection->x >= 0.0f ) > +{ > + tmin = ( pmin->x - prayposition->x ) / praydirection->x; > + tmax = ( pmax->x - prayposition->x ) / praydirection->x; > +} ... > +if ( tmax < 0.0f ) return FALSE; This w