Re: d3drm: Merge Direct3DRMCreate with its implementation.

2010-01-12 Thread Christian Costa
Dmitry Timoshkov a écrit : Christian Costa wrote: I'm not again clean-up at all but this dll is almost empty and this is likely there will be some patches preparing further submissions. Doing some clean-up between patches does not help much. Main purpose of my patch was to replace a

Re: d3drm: Merge Direct3DRMCreate with its implementation.

2010-01-11 Thread Dmitry Timoshkov
Christian Costa wrote: > I'm not again clean-up at all but this dll is almost empty and this is > likely there will be some patches preparing > further submissions. Doing some clean-up between patches does not help much. Main purpose of my patch was to replace a vtable in IDirect3DRMImpl by a p

Re: d3drm: Merge Direct3DRMCreate with its implementation.

2010-01-11 Thread Christian Costa
Dmitry Timoshkov a écrit : Christian Costa wrote: What the hell is the purpose of this patch ? Isn't the subject clear enough? Please calm down. Well yes and no. Why would you do that merge ? Direct3DRM_create is supposed to be called by Direct3DRMCreate or from class factory (wh

Re: d3drm: Merge Direct3DRMCreate with its implementation.

2010-01-11 Thread Dmitry Timoshkov
Christian Costa wrote: > What the hell is the purpose of this patch ? Isn't the subject clear enough? Please calm down. > d3drm.c is for the IDirect3DRMx objects implementations and there will > be a file for each other object. Once it's really needed you can create as much source files as yo

Re: d3drm: Merge Direct3DRMCreate with its implementation.

2010-01-11 Thread Christian Costa
What the hell is the purpose of this patch ? d3drm.c is for the IDirect3DRMx objects implementations and there will be a file for each other object. Direct3DRMCreate is just an entry point and BTW many wine DirectX dlls are implemented this way because some objects can be also created using th