Re: crtdll: Declare some variables static

2007-01-03 Thread Andrew Talbot
Robert Shearman wrote: > > However, it had an implicit "... but they are exported from this DLL." > Right. My brain has just caught up with you. As you can see, I'm trawling through the dlls looking for anything I can legitimately take out of the global namespace. I am trying to be as careful

Re: crtdll: Declare some variables static

2007-01-03 Thread Robert Shearman
Andrew Talbot wrote: Marcus Meissner wrote: Err, why? They are clearly exported from the .spec file and you just killed the exports? They likely are used by Windows programs. Ciao, Marcus Hi Marcus, I trusted the comment just before the declarations, which says: /* The following

Re: crtdll: Declare some variables static

2007-01-03 Thread Andrew Talbot
Marcus Meissner wrote: > Err, why? > > They are clearly exported from the .spec file and you just killed the > exports? > > They likely are used by Windows programs. > > Ciao, Marcus Hi Marcus, I trusted the comment just before the declarations, which says: /* The following data items are no

Re: crtdll: Declare some variables static

2007-01-03 Thread Marcus Meissner
On Wed, Jan 03, 2007 at 03:45:28PM +, Andrew Talbot wrote: > Changelog: > crtdll: Declare some variables static. Err, why? They are clearly exported from the .spec file and you just killed the exports? They likely are used by Windows programs. Ciao, Marcus