Re: cppcheck run against 1.27

2009-08-08 Thread Dan Kegel
Chris wrote: >>>[../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >>>deallocated pointer: fd - This just means your freeing an already freed >>>resource... This is more of a warning than anything >> >> Double frees are serious errors... double closes not so much. >> I don't see eit

Re: cppcheck run against 1.27

2009-08-08 Thread Mike Kaplinskiy
On Sat, Aug 8, 2009 at 4:56 AM, Marcus Meissner wrote: > On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: >> >> [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd > > I do not fully understand the code (keep fd open to have to lock > existing?), but it is in a fatal exit

re: cppcheck run against 1.27

2009-08-08 Thread Dan Kegel
Chris wrote: >... >[../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >deallocated pointer: fd - This just means your freeing an already freed >resource... This is more of a warning than anything Double frees are serious errors... double closes not so much. I don't see either on th

Re: cppcheck run against 1.27

2009-08-08 Thread chris ahrendt
Marcus Meissner wrote: > On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: > >> [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd >> > > I do not fully understand the code (keep fd open to have to lock > existing?), but it is in a fatal exit path. > >> [../wi

Re: cppcheck run against 1.27

2009-08-08 Thread Marcus Meissner
On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: > > [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd I do not fully understand the code (keep fd open to have to lock existing?), but it is in a fatal exit path. > [../wine-git/tools/fnt2bdf.c:219]: (error) Resource l

cppcheck run against 1.27

2009-08-07 Thread chris ahrendt
[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource