Re: PATCH: controls/menu.c case ranges

2004-07-22 Thread Marcus Meissner
On Thu, Jul 22, 2004 at 02:34:20PM -0700, Alexandre Julliard wrote: > Marcus Meissner <[EMAIL PROTECTED]> writes: > > > Another try on fixing the case range problems (WORD is unsigned, > > HBMMENU_CALLBACK is -1, so out of range of the switch). > > I think this is revealing a deeper problem with

Re: PATCH: controls/menu.c case ranges

2004-07-22 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > Another try on fixing the case range problems (WORD is unsigned, > HBMMENU_CALLBACK is -1, so out of range of the switch). I think this is revealing a deeper problem with that code, the magic value check should be done against the whole handle, not j

RE: controls/menu.c

2004-04-16 Thread Ge van Geldorp
> From: Dimitrie O. Paun > > On Fri, 16 Apr 2004, Ge van Geldorp wrote: > > > This fixes the black text on white background in AbiWord menus > > > > Changelog: > > Ge van Geldorp <[EMAIL PROTECTED]> > > Setup menu drawing colors before calling owner draw routine > > Good catch Ge, this was

Re: controls/menu.c

2004-04-16 Thread Dimitrie O. Paun
On Fri, 16 Apr 2004, Ge van Geldorp wrote: > This fixes the black text on white background in AbiWord menus > > Changelog: > Ge van Geldorp <[EMAIL PROTECTED]> > Setup menu drawing colors before calling owner draw routine Good catch Ge, this was really annoying, and maybe the most upsetting