Re: EverQuest2.exe and context.c

Dan Kegel wrote: > Chris Ahrendt wrote: >> Again on the goto's I was following what the site >> suggested was a good task to start with > > Where does it say that? I looked, but I couldn't find it. > Please let me know so I can go make sure it's accurate. > > Wine code is a bit like kernel code

re: EverQuest2.exe and context.c

Chris Ahrendt wrote: > Again on the goto's I was following what the site > suggested was a good task to start with Where does it say that? I looked, but I couldn't find it. Please let me know so I can go make sure it's accurate. Wine code is a bit like kernel code, it has slightly different con

Re: EverQuest2.exe and context.c

> The backtraces of the crash are attached in 12929 which is a general > catch all for the ATI issues. Well, no. 12929 is about a rather specific problem where fglrx crashes when trying to use GL_ATI_envmap_bumpmap or GL_ATI_separate_stencil. (And for what it's worth, that bug won't go anywhere unt

Re: EverQuest2.exe and context.c

Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> Vitaliy Margolen wrote: >>> Chris Ahrendt wrote: Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> Vitaliy Margolen wrote: >>> Chris Ahrendt wrote: Ok I ran make test and got the failure without running Everquest2

Re: EverQuest2.exe and context.c

Chris Ahrendt wrote: > Vitaliy Margolen wrote: >> Chris Ahrendt wrote: >>> Vitaliy Margolen wrote: Chris Ahrendt wrote: > Vitaliy Margolen wrote: >> Chris Ahrendt wrote: >>> Ok I ran make test and got the failure without running >>> Everquest2.exe let me attach the output of m

Re: EverQuest2.exe and context.c

Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> Vitaliy Margolen wrote: >>> Chris Ahrendt wrote: Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> Ok I ran make test and got the failure without running >> Everquest2.exe let me attach the output of maketest. I guess thats >>

Re: EverQuest2.exe and context.c

Chris Ahrendt wrote: > Vitaliy Margolen wrote: >> Chris Ahrendt wrote: >>> Vitaliy Margolen wrote: Chris Ahrendt wrote: > Ok I ran make test and got the failure without running > Everquest2.exe let me attach the output of maketest. I guess thats > a start eh? > You getti

Re: EverQuest2.exe and context.c

Chris Ahrendt wrote: > Vitaliy Margolen wrote: >> Chris Ahrendt wrote: >>> Ok I ran make test and got the failure without running Everquest2.exe >>> let me attach the output of maketest. I guess thats a start eh? >>> >> You getting off-topic too far here. Make test have nothing to do with >> your

Re: EverQuest2.exe and context.c

Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> Ok I ran make test and got the failure without running Everquest2.exe >> let me attach the output of maketest. I guess thats a start eh? >> > You getting off-topic too far here. Make test have nothing to do with > your game. Especially that you at

Re: EverQuest2.exe and context.c

Chris Ahrendt wrote: > Ok I ran make test and got the failure without running Everquest2.exe > let me attach the output of maketest. I guess thats a start eh? > You getting off-topic too far here. Make test have nothing to do with your game. Especially that you attached complete output of everyt

RE: EverQuest2.exe and context.c

> Ok I did a clean install.. rebuilt wine from the base 1.1.1 code put > the above patch into the context.c and reran EverQuest2.exe I put > export WINEDEBUG=+d3d,+sed before running and am attaching the trace. > (If you need more just send me a message and I will retry it. > I sti

RE: EverQuest2.exe and context.c

> why not remove this and go ahead and call ChoosePixelFormat? > If ChoosePixelFormat fails then we say we can't find a suitable pixel > format? This removes one problem when EverQuest2.exe runs where I get > 2-3 calls to WineD3D_ChoosePixelFormat Roderick has written this code, and he is on vaca

EverQuest2.exe and context.c

Stefan and all... in context.c the following lines: /* When findCompatible is set and no suitable format was found, let ChoosePixelFormat choose a pixel format in order not to crash. */ if(!iPixelFormat && !findCompatible) { ERR("Can't find a suita

Re: context.c diff file...

Hi Dan, most of that advice was good, but I'll comment on one thing you said: > Lastly, once the patch is clean and you can send it correctly (test on > yourself and compare with patches sent that get accepted), send it to > the correct list for patches, which is wine-patches, not wine-devel. It'

Re: context.c diff file...

On Thu, Jun 26, 2008 at 02:06:18PM -0400, [EMAIL PROTECTED] wrote: > ok sorry for cutting and pasting the whole routine.. did not see to do just > the diff ... > (give the old guy a break.. I am an architect now not a programmer ) > Your diff is getting corrupted. See all the ???: http://www.w

Re: context.c diff file...

On Thu, Jun 26, 2008 at 02:06:18PM -0400, [EMAIL PROTECTED] wrote: > ok sorry for cutting and pasting the whole routine.. did not see to do just > the diff ... > (give the old guy a break.. I am an architect now not a programmer ) Please pass at least the -u option for diff. Ciao, Marcus

context.c diff file...

ok sorry for cutting and pasting the whole routine.. did not see to do just the diff ... (give the old guy a break.. I am an architect now not a programmer ) here is the diff : 119d118 < 122d120 adapter->cfgs; 124,125c122,124 WineD3D_PixelFormat *cfgs = This->adapter->cfgs; > BOOL exa

Re: context.c

> Has anyone looked at the changes put on the list for context.c? James already replied: diff is your friend. As the site says, send a diff (in git format, or in unified diff format if for some bad reason you're not using git) if you want feedback, it's too hard to read your chan

Re: context.c

[EMAIL PROTECTED] wrote: > Has anyone looked at the changes put on the list for context.c? Just had > not heard anything.. > > I assume it is because I am new and all but still...just trying to help > per the request on the wine site =

context.c

Has anyone looked at the changes put on the list for context.c? Just had not heard anything.. I assume it is because I am new and all but still...just trying to help per the request on the wine site =) chris

RE: dlls/wintab32/context.c -- simpflication and HEADS UP!

Gerald Pfeifer wrote on Tuesday, January 01, 2008 6:03 PM: This code obviously was written with signed operands in mind. I wonder if they could get signed somewhere and this function simply uses the wrong datatype. > (I did not get _any_ response for my first mail a month ago > and I still belie

Re: dlls/wintab32/context.c -- simpflication and HEADS UP!

y first mail a month ago and I still believe the else-part looks bogus, but can we get at least this first cleanup in?) Gerald ChangeLog: Simplify condition in ScaleForContext(). Index: dlls/wintab32/context.c === RCS file:

dlls/wintab32/context.c -- simpflication and HEADS UP!

are bogus. Any expert who could help with a more extensive patch? Gerald ChangeLog: Simplify condition in ScaleForContext(). Index: dlls/wintab32/context.c === RCS file: /home/wine/wine/dlls/wintab32/context.c,v retrieving