On Sun, 28 May 2006, Vitaliy Margolen wrote:
Sunday, May 28, 2006, 12:19:30 PM, Andrew Talbot wrote:
On reflection, I think I need to look at constifying the structure members,
where possible, rather than unconstifying the values that are fed to them.
Exactly. Except that's the part that we c
Sunday, May 28, 2006, 12:19:30 PM, Andrew Talbot wrote:
> On reflection, I think I need to look at constifying the structure members,
> where possible, rather than unconstifying the values that are fed to them.
Exactly. Except that's the part that we can't do nothing about - that's the
way they ar
On reflection, I think I need to look at constifying the structure members,
where possible, rather than unconstifying the values that are fed to them.
-- Andy.
Robert Shearman wrote:
>
> Absolutely. We should avoid regressions at all costs, but making literal
> strings non-writable should help to uncover bugs.
>
Of course, what I am doing with the structure members is to say "These have
been declared as writeable (LPSTR pszXYZ); I don't know whether th
Andrew Talbot wrote:
Because I have had at least one patch like this accepted, I assumed what I
was doing was OK. I guess another way of preventing this warning would be
to use:
x.pszText = (LPSTR) "string";
Assuming there is no danger in using this method, then it is neater for a
single as
Hi Vitaliy,
I am having a go at the janitorial project of fixing certain compiler
warnings suggested at http://wiki.winehq.org/CompilerWarnings/.
When the -Wwrite-strings flag is set, code like this:
char *a = "string";
produces the message "warning: assignment discards qualifiers from poin
Saturday, May 27, 2006, 11:57:33 AM, Andrew Talbot wrote:
> Changelog:
> comctl32_tests: Janitorial: write-strings warning fix.
> diff -urN a/dlls/comctl32/tests/tab.c b/dlls/comctl32/tests/tab.c
> --- a/dlls/comctl32/tests/tab.c 2006-05-27 17:25:57.0 +0100
> +++
