Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

2013-06-17 Thread Ken Thomases
On Jun 18, 2013, at 1:26 AM, Dmitry Timoshkov wrote: > Daniel Jeliński wrote: > >> I'm quite sure you didn't mean to ignore return value of GetStockObject and >> leave logfont uninitialized here. > > GetStockObject(DEFAULT_GUI_FONT) can't fail. I think the question is: what does line 1917 do?

Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

2013-06-17 Thread Dmitry Timoshkov
Daniel Jeliński wrote: > I'm quite sure you didn't mean to ignore return value of GetStockObject and > leave logfont uninitialized here. GetStockObject(DEFAULT_GUI_FONT) can't fail. -- Dmitry.

Re: comctl32: Use default GUI font as a fallback instead of a (non-existent) Arial.

2013-06-17 Thread Daniel Jeliński
Hi Dmitry, After this patch got applied, the code looks like this: ( http://source.winehq.org/git/wine.git/blob/cc086f09ae46c77e6eb4a817ae567294d3f795ec:/dlls/comctl32/tab.c#l1914 ) 1914 if (!GetObjectW((infoPtr->hFont) ? 1915 infoPtr->hFont : GetStockObject(DEFAULT_GUI_FONT), 1916 sizeof(LOGFONTW)