Re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-09 Thread Stefan Dösinger
wrong with development process. > > I think that current development process isn't a problem at all. In fact > AJ is very good at what he is doing! > As far as I understand your patch ("comctl32: Fix invalid syntax.") was > rejected just because you forgot t

Re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-08 Thread L. Rahyen
sn't a problem at all. In fact AJ is very good at what he is doing! As far as I understand your patch ("comctl32: Fix invalid syntax.") was rejected just because you forgot to add proper (descriptive) changelog entry. What is the real problem is the lack of test

Re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-08 Thread Marcel Partap
hi base, >> If winehq.org is Alexandre's own property, this is something >> fundametally wrong again. Well.. then 'something' must be wrong with the linux kernel aswell.. how comes noone forked? hmmm.. > You may try to learn how things work in the Wine project by reading > the following threa

Re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-08 Thread Francois Gouget
On Fri, 8 Feb 2008, Bang Jun-young wrote: [...] > In fact, this is a well known mistake many newbie Win32 developers > make (and fix in minutes). It shouldn't have been in the tree in the > first place if he actually have read the patch. News flash!!! You too are allowed to review patches posted

Re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Dmitry Timoshkov
"Bang Jun-young" <[EMAIL PROTECTED]> wrote: >> People prefer to follow Alexandre's tree but nobody forces them to use it. > > If winehq.org is Alexandre's own property, this is something > fundametally wrong again. You may try to learn how things work in the Wine project by reading the following

re: Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Dan Kegel
Bang Jun-young wrote: >In fact, this is a well known mistake many newbie Win32 developers >make (and fix in minutes). It shouldn't have been in the tree in the >first place if he actually have read the patch. There are a lot of >easily catchable bugs in the tree, for example, potential security >ho

Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Bang Jun-young
On 2/7/08, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Bang Jun-young wrote: > > On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > >> "Bang Jun-young" <[EMAIL PROTECTED]> writes: > >> > >>> 18 hours passed, and it looks like Alexandre decided to ignore this...why? > >>> > >>> This fix i

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Michael Stefaniuc
Bang Jun-young wrote: > On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> "Bang Jun-young" <[EMAIL PROTECTED]> writes: >> >>> 18 hours passed, and it looks like Alexandre decided to ignore this...why? >>> >>> This fix is required for Wine to be built with VC2005/2008 (although >>> Alexand

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Bang Jun-young
On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Bang Jun-young" <[EMAIL PROTECTED]> writes: > > > 18 hours passed, and it looks like Alexandre decided to ignore this...why? > > > > This fix is required for Wine to be built with VC2005/2008 (although > > Alexandre doesn't seem to care ab

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Alexandre Julliard
"Bang Jun-young" <[EMAIL PROTECTED]> writes: > 18 hours passed, and it looks like Alexandre decided to ignore this...why? > > This fix is required for Wine to be built with VC2005/2008 (although > Alexandre doesn't seem to care about it). There's no need to count the hours, or to ask every day, e

Re: comctl32: Fix invalid syntax.

2008-02-06 Thread Bang Jun-young
18 hours passed, and it looks like Alexandre decided to ignore this...why? This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it). On 2/6/08, Bang Jun-young <[EMAIL PROTECTED]> wrote: > Any reason why this hasn't been committed? >