Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-28 Thread Michael Stefaniuc
On 04/28/2011 02:05 AM, Vitaliy Margolen wrote: On 04/27/2011 09:47 AM, Nikolay Sivov wrote: On 4/27/2011 17:53, Vitaliy Margolen wrote: On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local vari

Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-27 Thread Vitaliy Margolen
On 04/27/2011 09:47 AM, Nikolay Sivov wrote: On 4/27/2011 17:53, Vitaliy Margolen wrote: On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local variable passed as function parameter? Because there

Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-27 Thread Nikolay Sivov
On 4/27/2011 17:53, Vitaliy Margolen wrote: On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local variable passed as function parameter? Because there's no need to have different parent windows fo

Re: comctl32/tests: Remove practically unused parameters from test functions

2011-04-27 Thread Vitaliy Margolen
On 04/27/2011 01:14 AM, Nikolay Sivov wrote: Remove practically unused parameters from test functions So how is global variable any better then local variable passed as function parameter? IMHO this is s wrong thing to do - to move everything as global variables just to move it back whenev