Re: comctl32/tests: Added first TaskDialog test.

2011-06-13 Thread Nikolay Sivov
2011/6/13 André Hentschel : > Am 13.06.2011 00:09, schrieb Patrick Gauthier: >> - As a result of the previous comment, there would be no point to >>   generate the manifest as a file, as it could be loaded from a >>   resource (CreateActCtx supports this), that would seem cleaner to me >>   than ge

Re: comctl32/tests: Added first TaskDialog test.

2011-06-13 Thread Patrick Gauthier
On 06/13/11 06:54, André Hentschel wrote: > IIRC the reason for the temporary file is that we can easily turn the v6 > features on and off and AFAIK we can't if we have it "hardcoded" in a > resource. I did not mean to hardcode as a resource of type RT_MANIFEST id 1, but rather some random id, th

Re: comctl32/tests: Added first TaskDialog test.

2011-06-13 Thread André Hentschel
Am 13.06.2011 00:09, schrieb Patrick Gauthier: > - As a result of the previous comment, there would be no point to > generate the manifest as a file, as it could be loaded from a > resource (CreateActCtx supports this), that would seem cleaner to me > than generating temporary files. IIRC th

Re: comctl32/tests: Added first TaskDialog test.

2011-06-12 Thread Nikolay Sivov
On Mon, Jun 13, 2011 at 2:09 AM, Patrick Gauthier wrote: >> Hey, Patrick. >> >> Look at tests/listview.c for example to see how I load version 6 with >> activation context API. It doesn't work for some reason for XP SP3 (a >> glitch I don't understand), but works fine for everything else. All >> y

Re: comctl32/tests: Added first TaskDialog test. (try 2)

2011-06-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11662 Your paranoid android

Re: comctl32/tests: Added first TaskDialog test.

2011-06-12 Thread Patrick Gauthier
> Hey, Patrick. > > Look at tests/listview.c for example to see how I load version 6 with > activation context API. It doesn't work for some reason for XP SP3 (a > glitch I don't understand), but works fine for everything else. All > you need is v6util.h. > > Without version 6 activation this tes

Re: comctl32/tests: Added first TaskDialog test.

2011-06-11 Thread Nikolay Sivov
On Sun, Jun 12, 2011 at 9:32 AM, Patrick Gauthier wrote: > This patch relies on my previous patch that sets the ordinals right. > > Given that these functions would only be available on COMCTL32 v6.x, > Vista+, I added a win_skip if the APIs are not present. However unless > the test EXE has a man