Re: combo - implement GetComboBoxInfo

2005-03-16 Thread Thomas Weidenmueller
Dmitry Timoshkov wrote: Since you didn't provide your test app I wrote my own (attached). My comments are based on its results. Well, since I was lazy I wrote it in Delphi and you'd have to enter window handles yourself, I didn't attach it but since I keep being accused of tainted sources I tr

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread Dmitry Timoshkov
"Thomas Weidenmueller" <[EMAIL PROTECTED]> wrote: Since you didn't provide your test app I wrote my own (attached). My comments are based on its results. > The results of the research I just did: > > 1. GetComboBoxInfo works with all handles, even with handles not > belonging to the calling pro

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread C. Scott Ananian
On Tue, 15 Mar 2005, Alexandre Julliard wrote: The IsWindow check is useless, what you need is to verify that it's really a combobox. The right way to do that is probably to send a CB_GETCOMBOBOXINFO message instead. Since I'm working on a bug in the updown control which revolves around an IsWindo

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread Thomas Weidenmueller
Thomas Weidenmueller wrote: 4. It sets the last error code to ERROR_INVALID_MENU_HANDLE and returns FALSE if the window handle is invalid It's supposed to be ERROR_INVALID_WINDOW_HANDLE of course. Thomas

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread Thomas Weidenmueller
Alexandre Julliard wrote: Much worse, the class name is not a valid way of checking the Windows type. You really need to send a message. The results of the research I just did: 1. GetComboBoxInfo works with all handles, even with handles not belonging to the calling process 2. It does NOT send

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread Alexandre Julliard
Steven Edwards <[EMAIL PROTECTED]> writes: > Hi, > > --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > The IsWindow check is useless, what you need is to verify that it's > > really a combobox. The right way to do that is probably to send a > > CB_GETCOMBOBOXINFO message instead. > > How abo

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread Steven Edwards
Hi, --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > The IsWindow check is useless, what you need is to verify that it's > really a combobox. The right way to do that is probably to send a > CB_GETCOMBOBOXINFO message instead. How about something like this instead? Index: dlls/user/combo.c ==

Re: combo - implement GetComboBoxInfo

2005-03-15 Thread Alexandre Julliard
Steven Edwards <[EMAIL PROTECTED]> writes: > @@ -2296,7 +2295,18 @@ > BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box > */ > PCOMBOBOXINFO pcbi /* [in/out] combo box information */) > { > -FIXME("\n"); > -return FALSE; > +if (IsWindow(hwn

Re: combo - implement GetComboBoxInfo

2005-03-14 Thread Dmitry Timoshkov
"Dimitrie O. Paun" <[EMAIL PROTECTED]> wrote: > > +LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongA( hwndCombo, 0 ); > > Please use GetWindowLongW(), the combo box is fully Unicode. Or rather GetWindowLongPtrW(). -- Dmitry.

Re: combo - implement GetComboBoxInfo

2005-03-14 Thread Dmitry Timoshkov
"Steven Edwards" <[EMAIL PROTECTED]> wrote: > BOOL WINAPI GetComboBoxInfo(HWND hwndCombo, /* [in] handle to combo box > */ > PCOMBOBOXINFO pcbi /* [in/out] combo box information */) > { > -FIXME("\n"); > -return FALSE; > +LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindo

Re: combo - implement GetComboBoxInfo

2005-03-14 Thread Steven Edwards
--- "Dimitrie O. Paun" <[EMAIL PROTECTED]> wrote: > Please use GetWindowLongW(), the combo box is fully Unicode. OK I will hack it for him. This guy is new to C programing and I should have caught that. He has a bunch of VB apps that he uses this function in. > > +pcbi->hwndCombo = h

Re: combo - implement GetComboBoxInfo

2005-03-14 Thread Dimitrie O. Paun
On Mon, Mar 14, 2005 at 08:02:00PM -0800, Steven Edwards wrote: > -FIXME("\n"); > -return FALSE; > +LPHEADCOMBO lphc = (LPHEADCOMBO)GetWindowLongA( hwndCombo, 0 ); Please use GetWindowLongW(), the combo box is fully Unicode. > +pcbi->hwndCombo = hwndCombo; > +pcbi->hwnd