On Fri, Aug 19, 2011 at 02:46, Nowres Rafid wrote:
>
else {
+pos = string;
/* Remove any double quotes, which may be in the
middle, eg. cd "C:\Program Files"\Microsoft is ok */
-pos = string;
> That's a gratuitous change
while (*command) {
if (*command != '"')
Two more tips:
1) don't send HTML email to wine mailing lists
2) please be sure to run the conformance tests before submitting
patches, and fix any failures
Happily, your patch seems to cause a test to succeed:
...
../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p
cmd.exe_test.exe.so ba
On 17/08/2011 14:42, Dan Kegel wrote:
Frédéric Delanoy wote:
Nowres Rafid wrote:
how can I generate the expected file (.exp)?
It already exists in the source tree
I think Nowres meant, how can he update the .exp file
to match the expected output of his new test.
The answer is: run the new te
Frédéric Delanoy wote:
> Nowres Rafid wrote:
>> how can I generate the expected file (.exp)?
> It already exists in the source tree
I think Nowres meant, how can he update the .exp file
to match the expected output of his new test.
The answer is: run the new test, save its output,
and add it to t
2011/8/17 Nowres Rafid :
> On 17/08/2011 14:02, Frédéric Delanoy wrote:
>>
>> On Fri, Aug 12, 2011 at 19:14, Nowres Rafid
>> wrote:
>>>
>>> fixing cd ..@space@
>>>
>>> please ignore the previous patch.
>>
>> You didn't include any test in your patch.
>> All patches including a fix must have tests
On Fri, Aug 12, 2011 at 19:14, Nowres Rafid wrote:
> fixing cd ..@space@
>
> please ignore the previous patch.
You didn't include any test in your patch.
All patches including a fix must have tests confirming the bug is fixed
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13451
Your paranoid android
