2011/6/13 Frédéric Delanoy :
>> I'd like to see the code that implements @todo_wine@ submitted
>> in the same patch as the first test that uses it.
>
> I'll probably send them in a patch series; should be good enough, no?
Yes, that's fine.
2011/6/13 Dan Kegel :
>
> In the meantime, please either send a separate patch
> that removes todo_space, or just leave todo_space alone for now.
>
>>> To avoid adding dead code, it might be nice to
>>> see a test that actually uses your new keyword.
>>
>> I've made several mkdir tests with it, and
2011/6/13 Frédéric Delanoy :
> But OK an array seemed odd to me as well... it was probably done so
> that sizeof(foo_cmd) could be used in memcp(expected_ptr, foo_cmd,
> sizeof(foo_cmd)).
Nah, looking at the code, it was so that sizeof() would not include
the trailing NUL.
But compare_string is j
On 06/13/11 14:02, Frédéric Delanoy wrote:
> On Mon, Jun 13, 2011 at 13:48, Jacek Caban wrote:
>> Hi Frédéric,
>>
>> On 06/12/11 23:01, Frédéric Delanoy wrote:
>>> -
>>> +is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl);
>>> +
>> There is no need to add such logic directly to test_output,
On Mon, Jun 13, 2011 at 13:48, Jacek Caban wrote:
> Hi Frédéric,
>
> On 06/12/11 23:01, Frédéric Delanoy wrote:
>> -
>> + is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl);
>> +
>
> There is no need to add such logic directly to test_output, this can be
> returned from comare_line.
Do you
Hi Frédéric,
On 06/12/11 23:01, Frédéric Delanoy wrote:
> -
> +is_todo_wine = is_todo_wine_line(exp_ptr, exp_nl);
> +
There is no need to add such logic directly to test_output, this can be
returned from comare_line.
Jacek
2011/6/13 Dan Kegel :
> I agree @todo_space@ should go; it's never used, so it's dead code now.
> Tempting to say that removing it should be a separate patch,
> rather than combining that with adding a new feature.
Well, maybe but I didn't see its usefulness when @todo_wine@ is
introduced. It coul
I agree @todo_space@ should go; it's never used, so it's dead code now.
Tempting to say that removing it should be a separate patch,
rather than combining that with adding a new feature.
Since all the @keywords@ are poorly documented,
I'm glad to see an unused one go.
Your generic @todo_wine@ keyw
