On 11/01/2010 10:47 PM, Jacek Caban wrote:
Why do you need this? AFAICS the change to compare_line should be enough.
In wine/programs/cmd/tests there are 2 files :
+ test_builtins.cmd
+ test_builtins.cmd.exp
The first one is a kind of .bat on windows.
The wine cmd read line after line and execu
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=6689
Your paranoid android.
Hi Alexandre,
On 11/1/10 4:23 PM, GOUJON Alexandre wrote:
+/* Substitute escaped spaces with real ones */
+static char* replace_escaped_spaces(const char *data, DWORD size, DWORD
*new_size)
Why do you need this? AFAICS the change to compare_line should be enough.
Jacek
GOUJON Alexandre wrote:
> On 11/01/2010 03:12 PM, Vitaliy Margolen wrote:
> >> +static const char escaped_space[] = "@space@";
> >> +DWORD len_space = strlen(escaped_space);
> > The better way to calculate size of a static string, which is a
> > compile time calculation. strlen() call is
On 11/01/2010 03:12 PM, Vitaliy Margolen wrote:
+static const char escaped_space[] = "@space@";
+DWORD len_space = strlen(escaped_space);
The better way to calculate size of a static string, which is a
compile time calculation. strlen() call is a runtime.
The better way is ... ?
In comp
On 11/01/2010 07:37 AM, GOUJON Alexandre wrote:
Hi everyone,
I'm trying to fix the wine cmd behavior but as this 5th try differs greatly
with the previous one, I'd like to have some feedback before submitting it.
If you have any question, just let me know.
Thanks is advance.
+static con
Hi everyone,
I'm trying to fix the wine cmd behavior but as this 5th try differs
greatly with the previous one, I'd like to have some feedback before
submitting it.
If you have any question, just let me know.
Thanks is advance.
diff --git a/programs/cmd/tests/batch.c b/programs/cmd/tests/batc
Alexandre Goujon writes:
> I was looking for a forbidden char in batch files but just I found
> accentuated chars whereas I wanted a single (not wide) char.
> Finally, I found it in the ASCII table.
> The \x1a character name is SUBSTITUTE and is exactly what we need.
It means end of file on Win
Alexandre Goujon writes:
> @@ -11,6 +25,8 @@ echo.
> echo .
> echo.word
> echo .word
> +echo word
> +echo word
You need some escaping mechanism for these trailing spaces too.
--
Alexandre Julliard
julli...@winehq.org
Alexandre Goujon writes:
> -...@pwd@>echo Tests for cmd's builtin comma...@todo_space@
> +...@pwd@>echo Tests for cmd's builtin commands
You'll need to define a @space@ symbol, normal trailing spaces will get
mangled.
--
Alexandre Julliard
julli...@winehq.org
On 10/03/2010 03:37 PM, Jacek Caban wrote:
@todo_space@ is meant to do tests in todo_wine block. You should
change @todo_space@ to spec in .exp file instead. If we're convinced
that the whole keyword is not useful anymore, the whole handling code
should be removed (although I think we'd better
On 10/3/10 1:18 PM, Alexandre Goujon wrote:
---
programs/cmd/tests/batch.c |2 +-
programs/cmd/wcmdmain.c|3 +++
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/programs/cmd/tests/batch.c b/programs/cmd/tests/batch.c
index cc8c020..d7a5e84 100644
--- a/programs/cmd
12 matches
Mail list logo
