Changelog:
- use retCode smarter (undoing a few bits of myself)
- add file_operation_invalid_handle(), file_operation_on_data(),
file_operation_invalid_attr() instead of inline code
I put back the line the discussion was about - I thought about it and I
probably was not thinking the right way;
If t
Joris Huizer wrote:
>That line can be removed as
>nFileOp = *(lpFileOp)
>on the first line - the variable is never changed after that (yeah, if
>we really like, we could get rid of it)
>I hadn't removed it just like that, yet - but as it is useless, it can
>be removed.
I wouldn't do that! This
Juan Lang wrote:
Hi Joris,
pFromFile and pToFile are treated oddly. Pass them as WCHAR pointers to
file_operation_on_data, not as pointers to WCHAR pointers. The
implementation of file_operation_on_data does not behave the same way as
the code it replaced.
You want something like:
+static int fil
Hi Joris,
pFromFile and pToFile are treated oddly. Pass them as WCHAR pointers to
file_operation_on_data, not as pointers to WCHAR pointers. The
implementation of file_operation_on_data does not behave the same way as
the code it replaced.
You want something like:
+static int file_operation_on_
Hi,
As you can see in the attached patch file, I wrote a function
file_operation_on_data() which uses a WIN32_FIND_DATAW to do a file
operation; however, for some reason, tests start to fire when using the
function:
../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p
shell32_test.e