That's ok with me.Thanks for the explanation. So Valgrind will report these
"intentional" memory leaks in addition to the "unintentional" ones. Correct?
2013/5/21 Dmitry Timoshkov
> Christian Costa wrote:
>
> > Out of curiosity. Not freeing these memory allocations shouldn't disturb
> > Valgri
Christian Costa wrote:
> Out of curiosity. Not freeing these memory allocations shouldn't disturb
> Valgrind to report false memory leaks?
Avoiding heap access on process exit should avoid possible dead locks
in case a terminated by ExitProcess thread holds the heap lock.
--
Dmitry.
Out of curiosity. Not freeing these memory allocations shouldn't disturb
Valgrind to report false memory leaks?
2013/5/21 Alexandre Julliard
> Dmitry Timoshkov writes:
>
> > Alexandre Julliard wrote:
> >
> >> >>case DLL_PROCESS_DETACH:
> >> >> -msvcrt_free_popen_data();
> >> >> m
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> >>case DLL_PROCESS_DETACH:
>> >> -msvcrt_free_popen_data();
>> >> msvcrt_free_io();
>> >> +if (lpvReserved) break;
>> >> +msvcrt_free_popen_data();
>> >> msvcrt_free_mt_locks();
>> >> msvcrt_free_console();
Alexandre Julliard wrote:
> >>case DLL_PROCESS_DETACH:
> >> -msvcrt_free_popen_data();
> >> msvcrt_free_io();
> >> +if (lpvReserved) break;
> >> +msvcrt_free_popen_data();
> >> msvcrt_free_mt_locks();
> >> msvcrt_free_console();
> >> msvcrt_free_args();
> >
> >
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>>case DLL_PROCESS_DETACH:
>> -msvcrt_free_popen_data();
>> msvcrt_free_io();
>> +if (lpvReserved) break;
>> +msvcrt_free_popen_data();
>> msvcrt_free_mt_locks();
>> msvcrt_free_console();
>> msvcrt_free_a
Alexandre Julliard wrote:
>case DLL_PROCESS_DETACH:
> -msvcrt_free_popen_data();
> msvcrt_free_io();
> +if (lpvReserved) break;
> +msvcrt_free_popen_data();
> msvcrt_free_mt_locks();
> msvcrt_free_console();
> msvcrt_free_args();
Shouldn't msvcrt_free_io() be
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23267
Your paranoid android
On 12/11/20 5:29, Alexandre Julliard wrote:
> Aric Stewart writes:
>
>> @@ -495,9 +518,14 @@ static DWORD WINAPI QTSplitter_loading_thread(LPVOID
>> data)
>> to try to minimize that.
>>*/
>>
>> -while(GetMovieLoadState(This->pQTMovie) < kMovieLoadStateComplet
Aric Stewart writes:
> @@ -495,9 +518,14 @@ static DWORD WINAPI QTSplitter_loading_thread(LPVOID
> data)
> to try to minimize that.
> */
>
> -while(GetMovieLoadState(This->pQTMovie) < kMovieLoadStateComplete)
> +while(This->pQTMovie && GetMovieLoadState(T
Alexander,
You want to google the paper titled "Defining speaker locations in
multi-channel streams and WDM audio drivers using the
WAVEFORMATEXTENSIBLE structure" by Carsten Schulz to learn a lot about
channel mapping as performed by w2k. It's a pity there's nothing like
it for xp or w7!
Wine's
Alexander,
I'm not familiar with dsound
+ if (ichannels > 2)
+ FIXME("Conversion from %u to %u channels is not implemented,
falling back to stereo", ichannels, ochannels);
+ dsb->mix_channels = 2;
Does you code support 8 channels? Look through git history, and
you'll se
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13580
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=13576
Your paranoid android
On 06/23/2011 08:12 PM, Andrew Eikum wrote:
+if(dwFlags& WAVE_FORMAT_QUERY)
+TRACE("WAVE_FORMAT_QUERY requested!\n");
How is removing the spaces for all these if/else statements an
improvement? It's also not consistent with the rest of the winmm code.
--
Cheers,
Paul.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=10918
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=10855
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=7719
Your paranoid android.
Hello,
Alexander Kochetkov wrote:
> The code like
> static inline MyObject *impl_from_IMyInterface(IMyInterface *iface)
> {
> return (MyObject*)((char*)iface - FIELD_OFFSET(MyObject,
> IMyInterface_iface));
> }
>
> could be replaced with
> static inline MyObject *impl_from_IMyInterface(IMyInt
Hi all,
The code like
static inline MyObject *impl_from_IMyInterface(IMyInterface *iface)
{
return (MyObject*)((char*)iface - FIELD_OFFSET(MyObject,
IMyInterface_iface));
}
could be replaced with
static inline MyObject *impl_from_IMyInterface(IMyInterface *iface)
{
return container_of(MyO
Hi all,
As many of you probably know, we currently have no standard way for
implementing COM objects in Wine. We use different techniques all over
the place. Some of them are better, other are worse or even ugly.
Together with Alexandre, we've chosen the technique that we believe is
the best
GOUJON Alexandre writes:
> On 08/30/2010 11:21 AM, Alexandre Julliard wrote:
>> Now you are overdoing it. I said to remove broken() for minor spelling
>> differences, not for everything. For instance confusing 936 and 950
>> codepages for Chinese is broken, it's not just a spelling difference
> S
On 08/30/2010 11:21 AM, Alexandre Julliard wrote:
Now you are overdoing it. I said to remove broken() for minor spelling
differences, not for everything. For instance confusing 936 and 950
codepages for Chinese is broken, it's not just a spelling difference
Sorry, I'm trying to do my best but
N
Alexandre Goujon writes:
> I removed all broken() and ran the tests on all WineTestBot machines
> (https://testbot.winehq.org/JobDetails.pl?Key=4829)
> Then, I cleaned up tests accordingly : removed superflous broken() and
> extending ok().
> (https://testbot.winehq.org/JobDetails.pl?Key=4831)
On 02/07/2010 04:56 PM, Paul Vriens wrote:
On 02/07/2010 04:46 PM, Hans Leidekker wrote:
On Sunday 07 February 2010 16:24:11 Paul Vriens wrote:
if (OpenSSL_ssl_handle)
@@ -305,6 +297,12 @@ void NETCON_unload(void)
pSSL_CTX_free(ctx);
wine_dlclose(OpenSSL_ssl_handle, NULL, 0);
}
+ if (ssl_locks
On Sunday 07 February 2010 16:24:11 Paul Vriens wrote:
> > if (OpenSSL_ssl_handle)
> > @@ -305,6 +297,12 @@ void NETCON_unload(void)
> > pSSL_CTX_free(ctx);
> > wine_dlclose(OpenSSL_ssl_handle, NULL, 0);
> > }
> > +if (ssl_locks)
> > +{
> > +int
On 10/27/2009 10:04 AM, Hans Leidekker wrote:
Found by valgrind.
---
dlls/wininet/netconnection.c | 14 ++
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c
index 97c764f..16cce40 100644
--- a/dlls/wininet/n
Hi Detlef,
Detlef Riekenberg schreef:
On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote:
+{
+/* FIXME: Still a memory leak.. */
This should be fixed before sending to wine-patches
The original code had no way to handle it, and msdn doesn't mention how
to handle
On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote:
> +{
> +/* FIXME: Still a memory leak.. */
This should be fixed before sending to wine-patches
--
By by ... Detlef
On Fri, 19 Jun 2009 20:01:15 +1000
Ben Klein wrote:
>
> What I'd like to see is an option to delete an entire thread of
> comments (ideally from an arbitrary point in the thread) in one hit.
> Usually, the comments that follow a post are meaningless without that
> post.
>
That was was fixed ba
2009/6/19 Ken Sharp :
>
>
> Ben Klein wrote:
>
>> What I'd like to see is an option to delete an entire thread of
>> comments (ideally from an arbitrary point in the thread) in one hit.
>> Usually, the comments that follow a post are meaningless without that
>> post.
>
> This is the default action
Ben Klein wrote:
What I'd like to see is an option to delete an entire thread of
comments (ideally from an arbitrary point in the thread) in one hit.
Usually, the comments that follow a post are meaningless without that
post.
This is the default action (changed in the last few months).
O
2009/6/19 Florian Köberle :
> Hi,
>
> I now became one of the application maintainers of Warcraft 3 The Frozen
> Throne and got asked to cleanup the comments. I started to do so, but
> there are just to much comments. I stopped deleting with 459 comments
> remaining.
> See: (http://appdb.winehq.org
Hi,
I now became one of the application maintainers of Warcraft 3 The Frozen
Throne and got asked to cleanup the comments. I started to do so, but
there are just to much comments. I stopped deleting with 459 comments
remaining.
See: (http://appdb.winehq.org/objectManager.php?sClass=version&iId=312
Jacek Caban <[EMAIL PROTECTED]> writes:
> diff --git a/dlls/mshtml/install.c b/dlls/mshtml/install.c
> index 731af60..2437797 100644
> --- a/dlls/mshtml/install.c
> +++ b/dlls/mshtml/install.c
> @@ -18,33 +18,23 @@
>
> #include "config.h"
>
> -#include
> +#include "mshtml_private.h"
> +#incl
Jacek Caban <[EMAIL PROTECTED]> writes:
> diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h
> index c981348..e0c94c3 100644
> --- a/dlls/mshtml/mshtml_private.h
> +++ b/dlls/mshtml/mshtml_private.h
> @@ -16,6 +16,19 @@
> * Foundation, Inc., 51 Franklin St, Fifth Floor, Bos
Am Donnerstag, 19. Juli 2007 09:10 schrieb H. Verbeet:
> I think the flag is fine. Executing that part of the code or not
> doesn't really depend on the surface type. GDI surfaces would never be
> attached to an FBO anyway, it's the GL_LIMITS(buffers) that would
> cause problems here. Making sure t
On 19/07/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
What I meant was that selecting the gl codepath or the no gl codepath. This is
preferably done by calling a COM method on the right vtable(d3d surface / non
d3d surface). My first patch(never sent here) checked the vtable address to
find out
Am Donnerstag, 19. Juli 2007 00:13 schrieb H. Verbeet:
> On 18/07/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> > This code does not really have a home. For one part the device is in
> > charge of managing the gl fbos, on the other hand this is gl surface
> > specific code and should go into IWi
On 18/07/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
This code does not really have a home. For one part the device is in
charge of managing the gl fbos, on the other hand this is gl surface
specific code and should go into IWineD3DSurface::Release.
No, the surface release code shouldn't kno
On 2/27/07, Misha Koshelev <[EMAIL PROTECTED]> wrote:
Looking back at James comments, maybe I did have a little too much
commenting there :)
You're sending patches that change code that hasn't been committed
yet. Instead, you need to go back and change the original patch and
resend.
--
James
On 14/01/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> How about something like R2VB?
I think we can implement R2VB if we want it(it is an ATI hack) by just setting
a VBO as a render target. The extensions imply that this is supposed to work,
although the performance isn't guaranted to be opti
Am Freitag 12 Januar 2007 20:06 schrieb Christoph Bumiller:
> Stefan Dösinger wrote:
> > We will need software shaders for a correct implementation of
> > IWineD3DDevice::ProcessVertices. It supports Vertex shaders, but I
> > don't really think OpenGL feedback mode is what we want here.
> >
> > May
Am Samstag 13 Januar 2007 21:37 schrieb H. Verbeet:
> On 12/01/07, Christoph Bumiller <[EMAIL PROTECTED]> wrote:
> > Stefan Dösinger wrote:
> > > We will need software shaders for a correct implementation of
> > > IWineD3DDevice::ProcessVertices. It supports Vertex shaders, but I
> > > don't really
On 12/01/07, Christoph Bumiller <[EMAIL PROTECTED]> wrote:
Stefan Dösinger wrote:
> We will need software shaders for a correct implementation of
> IWineD3DDevice::ProcessVertices. It supports Vertex shaders, but I
> don't really think OpenGL feedback mode is what we want here.
>
> Maybe we shoul
Stefan Dösinger wrote:
We will need software shaders for a correct implementation of
IWineD3DDevice::ProcessVertices. It supports Vertex shaders, but I
don't really think OpenGL feedback mode is what we want here.
Maybe we should remove it for now, but keep the code somewhere(in the
wiki maybe).
Stefan Dösinger wrote:
Am Samstag 06 Januar 2007 22:25 schrieb Ivan Gyurdiev:
Stefan Dösinger wrote:
Now that almost everything is gone from drawPrimitiveDrawStrided we don't
need a subfunction for calling drawStridedSlow/Fast any longer
I think while we're cleaning up things, a
Am Samstag 06 Januar 2007 22:25 schrieb Ivan Gyurdiev:
> Stefan Dösinger wrote:
> > Now that almost everything is gone from drawPrimitiveDrawStrided we don't
> > need a subfunction for calling drawStridedSlow/Fast any longer
>
> I think while we're cleaning up things, all of software shaders should
Stefan Dösinger wrote:
Now that almost everything is gone from drawPrimitiveDrawStrided we don't need
a subfunction for calling drawStridedSlow/Fast any longer
I think while we're cleaning up things, all of software shaders should
be removed.
There's tons of code in drawprim and *shader.c
On Sunday 13 August 2006 14:44, Kai Blin wrote:
> ---
> dlls/secur32/ntlm.c | 372
> ++-
> 1 files changed, 164 insertions(+), 208 deletions(-)
After sending in the fixes for my "Make AcceptSecurityContext behaviour
consistent with Windows, try2"
Chris Morgan wrote:
Eliminate redundant parameters from these functions. Have version class check
to see if the $iTestingId seems valid.
Patch removes a query for each call to testResult::ShowTestResult() because we
don't actually have to re-query the database for information already stored
- Original Message -
From: "Jacek Caban" <[EMAIL PROTECTED]>
> @@ -78,29 +77,35 @@ static HRESULT WINAPI PersistMoniker_IsD
> static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL
fFullyAvailable,
> IMoniker *pimkName, LPBC pibc, DWORD grfMode)
> {
> -FIXME
On Wed, 02 Feb 2005 21:34:00 +0100, Paul van Schayck wrote:
> Changelog:
> Clean up about dialog. Remove groupbox, position logo correctly.
Cool! If you want to do some winecfg hacking integrating the drive
detection with wineprefixcreate is like a 5 minute job.
My apologies for not responding, I had attempted to
sign up for the list, and that had failed. Oops! Now,
here I am. :)
Paul van Schayck said, about the <> ..
oops, that was a mistake in my search/replace.. I
thought I had fixed all of those occurences that I
made.
Also, for the !loggedin()
Can you post a new version with the fixes that people replied with? I think
the rest of the patch looks good.
Chris
On Thursday 23 December 2004 4:38 am, Eric Blade wrote:
> The attached patch includes a lot of cleaning up,
> mostly to HTML, a bit to some PHP.
>
>
>
>
>
>
On czwartek 23 grudzieÅ 2004 05:44 pm, Jonathan Ernst wrote:
> Le jeudi 23 dÃcembre 2004 Ã 22:39 +0100, Paul van Schayck a Ãcrit :
> > Hey Eric,
> >
> > On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <[EMAIL PROTECTED]>
wrote:
> > > The attached patch includes a lot of cleaning up,
> > > mos
Le jeudi 23 dÃcembre 2004 Ã 22:39 +0100, Paul van Schayck a Ãcrit :
> Hey Eric,
>
> On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <[EMAIL PROTECTED]>
> wrote:
> > The attached patch includes a lot of cleaning up,
> > mostly to HTML, a bit to some PHP.
>
> What's this supposed to do:
>
Hey Eric,
On Thu, 23 Dec 2004 01:38:02 -0800 (PST), Eric Blade <[EMAIL PROTECTED]> wrote:
> The attached patch includes a lot of cleaning up,
> mostly to HTML, a bit to some PHP.
What's this supposed to do:
if(!$tempResult)
{
- echo "$query \n";
+ echo "$query <>\
webupdate fails caused by this error. What function has to clean up the
ending \r?
Thanks
--
Uwe Bonnes[EMAIL PROTECTED]
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
- Tel. 06151 162516 Fax. 06151 164321 --
Index: wine/dlls/wininet/tests
59 matches
Mail list logo
