Dimi Paun wrote:
>
> On Wed, September 13, 2006 1:18 pm, Dan Kegel wrote:
>> Offhand that looks like a more serious change than you thought.
>> You'd better either really understand the code, or
>> add a conformance test that shows this fixes a bug, IMHO.
>
> Agreed. But that is confusing code,
On Wed, September 13, 2006 1:18 pm, Dan Kegel wrote:
> Offhand that looks like a more serious change than you thought.
> You'd better either really understand the code, or
> add a conformance test that shows this fixes a bug, IMHO.
Agreed. But that is confusing code, it should have a /* fallthrou
On 9/13/06, Andrew Talbot <[EMAIL PROTECTED]> wrote:
On Wednesday 13 September 2006 04:22, you wrote:
> Does adding the breaks fix conformance tests?
No, I haven't fixed anything with this patch: it was a neutral one, in that
respect. I just put it in because I perceived that those switch statem
On 13/09/06, Andrew Talbot <[EMAIL PROTECTED]> wrote:
Changelog:
cabinet: Add breaks to switch statements.
diff -urN a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c
--- a/dlls/cabinet/fci.c2006-09-12 11:55:48.0 +0100
+++ b/dlls/cabinet/fci.c2006-09-12 23:29:02.000
