Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Kees Cook
On Tue, Apr 05, 2005 at 01:07:14AM +0900, Mike McCormack wrote: > It's probably better to keep it consistent with what the rest of Wine does. I'd really like to push back on this. The traces become unreadable as the various function names change. I think the debugging as I have it is more usef

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Mike McCormack
Kees Cook wrote: It's probably better to keep it consistent with what the rest of Wine does. I'd really like to push back on this. The traces become unreadable as the various function names change. I think the debugging as I have it is more useful than how it looks with only "TRACE" calls. The

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Mike McCormack
Kees Cook wrote: Actually, I did that to avoid the line prefix that "TRACE" adds. All the stuff where I call the dbg functions directly are part of helper functions, and seeing their names is confusing while watching a Protect/Unprotect session. It's probably better to keep it consistent with w

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Kees Cook
On Mon, Apr 04, 2005 at 03:01:53PM +0900, Mike McCormack wrote: > Perhaps you could make it work "right" by using a key stored in ssh-agent? Well, by working "right", it means that taking a cipher/entropy from Windows and calling CryptUnprotectData on it in Wine would return the plain text. Thi

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Kees Cook
On Sun, Apr 03, 2005 at 11:56:34PM -0500, James Hawkins wrote: > we do it should be encapsulated. What I'm getting at is that just > because this implementation is wine-specific doesn't mean some of the > implementation data should go in Software\Wine. Software\Wine is > where the configurations

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Kees Cook
On Sun, Apr 03, 2005 at 11:04:53PM -0500, James Hawkins wrote: > On Apr 3, 2005 10:12 PM, Kees Cook <[EMAIL PROTECTED]> wrote: > > To store the triplets, these functions use the registry: > > > > Registry Layout: > > HKEY_CURRENT_USER\Software\Wine\Crypt\ProtectData\Map\[index] > > Cip

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-04 Thread Michael Jung
On Monday 04 April 2005 08:01, Mike McCormack wrote: > Kees Cook wrote: > > This patch implements a functional replacement for crypt32.dll's > > CryptProtectData and CryptUnprotectData. It does _not_ perform any > > encrypt/decryption, but rather tracks the cipher/entropy/plain triplets > > so tha

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-03 Thread Mike McCormack
rhaps you could make it work "right" by using a key stored in ssh-agent? diff -u -p -u -p -r1.92 ChangeLog Just writing a ChangeLog entry like this is OK: ChangeLog: * Added black-box implementation of CryptProtectData/CryptUnprotectData. You don't need to try patch ChangeLog, because

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-03 Thread James Hawkins
On Apr 4, 2005 12:00 AM, Kees Cook <[EMAIL PROTECTED]> wrote: > Sure, that's fine by me. I wasn't really sure where to put it, but it's > easy to change; it's just a path at the top of the file. In looking > around at other examples, it seemed the most sensible. Is there a > "normal" implementat

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-03 Thread James Hawkins
On Apr 3, 2005 11:44 PM, Kees Cook <[EMAIL PROTECTED]> wrote: > Windows doesn't store the results anywhere: it's just a symmetric crypto > function. Since we don't know the function, we have to store the > original data somewhere so we can return it later. Since this is > entirely a Wine-only imp

Re: black-box implementation of CryptProtectData/CryptUnprotectData

2005-04-03 Thread James Hawkins
On Apr 3, 2005 10:12 PM, Kees Cook <[EMAIL PROTECTED]> wrote: > To store the triplets, these functions use the registry: > > Registry Layout: > HKEY_CURRENT_USER\Software\Wine\Crypt\ProtectData\Map\[index] > Cipher: HEX string > Entropy: HEX string > Da