Hi Vitaliy,
Thanks a lot for your feedback!
Vitaliy Margolen wrote:
Julius Schwartzenberg wrote:
You don't need to use memcpy to copy structures. Simple assignment is
enough. Eg: cah->mah = defmah;
I didn't know that. I fixed it now here :)
For tests you should always specify full path. He
Julius Schwartzenberg wrote:
> +static void init_test_struct(COMMON_AVI_HEADERS *cah)
> +{
> +memcpy(&cah->mah, &defmah, sizeof(defmah));
> +memcpy(&cah->ash0, &defash0, sizeof(defash0));
> +memcpy(&cah->ash1, &defash1, sizeof(defash1));
> +memcpy(&cah->pcmwf, &defpcmwf, sizeof(defp
Hi André
André Hentschel wrote:
> Julius Schwartzenberg schrieb:
>> What do you think of the
>> general idea of the tests?
>
> As i cant proof correctness here, i just can say that the general
idea is great.
> Until Bug 14085 is fixed you can todo_wine it out. Further i think
you can leave the
Hi Dmitry,
Thanks a lot for your feedback! I should've solved most issues you
pointed me at. I have attached a new version of the patch.
Dmitry Timoshkov wrote:
Indentation of above structure and all others below this one look strange.
4 spaces would be quite enough.
This was supposed to re
Hi Julius,
"Julius Schwartzenberg" wrote:
+#include "api_test.h"
If the definitions in api_test.h are used only in 1 source file there is no
need to create an .h file at all, just place all the data in that source file.
+void init_test_struct(COMMON_AVI_HEADERS *cah)
This should be stati
Julius Schwartzenberg schrieb:
> What do you think of the
> general idea of the tests?
Hi Julius,
As i cant proof correctness here, i just can say that the general idea is great.
Until Bug 14085 is fixed you can todo_wine it out. Further i think you can
leave the data in the c-file(we also have r
Hi,
I still have some fixes for avifile here, but because they are quite
nasty, I thought it'd be useful to have proper tests to show the fixes
are really correct.
Unfortunately there is still a problem with the avifile tests as Detlef
indicated in this mail:
http://www.wineh
