Re: asserts in wine

2010-03-16 Thread Dan McDonald
On 03/07/2010 10:35 AM, Vitaliy Margolen wrote: > On 03/07/2010 04:38 AM, Reece Dunn wrote: >> 2/ dlls should be changed to a SetLastError or failure return code >> (depending on the API) -- otherwise, the program triggering this will >> be killed with no information as to what happened. > This

Re: asserts in wine

2010-03-07 Thread Vitaliy Margolen
On 03/07/2010 04:38 AM, Reece Dunn wrote: > As a general principle, assert in: > 1/ tests should be changed to an ok and possibly a skip -- > otherwise, the test results are reported as a crash, making it harder > to find out where the problem is. +1 In most cases they check for something that s

asserts in wine

2010-03-07 Thread Reece Dunn
Hi, After seeing Gerald Pfeifer's patch, I decided to see how many asserts were used in wine. $ find . -type f -iname *.c -exec grep -H assert '{}' \; > assert1.log This returns 2313 matching lines, some of which are including . $ cat assert1.log | sed -e 's/:.*//' | sort | uniq -c | sort -n >