Re: advpack:reg.c: Cast-qual warning fix

2006-08-28 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > So am I right to infer that, in such cases, you would rather that I leave > the disqualifying casts in place? For the moment, yes. Let's look at this again once all the places that can be fixed properly are done. -- Alexandre Julliard [EMAIL PROTECTED

Re: advpack:reg.c: Cast-qual warning fix

2006-08-28 Thread Andrew Talbot
Alexandre Julliard wrote: > I don't think we want to duplicate strings just because of the > warning. If the string really needs to be writable sure, but if it's > just because of MS broken prototypes it's not worth the extra cost. > So am I right to infer that, in such cases, you would rather t

Re: advpack:reg.c: Cast-qual warning fix

2006-08-28 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > --- a/dlls/advpack/reg.c 2006-06-14 12:55:31.0 +0100 > +++ b/dlls/advpack/reg.c 2006-08-28 17:00:18.0 +0100 > @@ -255,11 +255,14 @@ > /* FIXME: read AdvOptions val for dwFlags */ > ZeroMemory(&cabinfo, sizeof(CABINFOW)