Re: advpack: Implement LaunchINFSection on top of DoInfInstall

2006-01-13 Thread James Hawkins
On 1/13/06, Markus Amsler <[EMAIL PROTECTED]> wrote: > > I'm aware of that. We just have different approaches. Mine is from > higher level functions to lower level, yours the other way round. Our > approaches are not exclusive, we can simply meet in the middle (I know i > took the easier way :-)).

Re: advpack: Implement LaunchINFSection on top of DoInfInstall

2006-01-13 Thread Markus Amsler
James, I just saw your advpack patches. Only patch 4 (* Add stubs for the file save/restore functions), Makefile.in gets a merge conflict with mine first 1 (Move inf install functions to install.c ). The rest applies fine (some offset warnings), and builds without warning. Should I rediff again

Re: advpack: Implement LaunchINFSection on top of DoInfInstall

2006-01-13 Thread Markus Amsler
James Hawkins wrote: On 1/12/06, Markus Amsler <[EMAIL PROTECTED]> wrote: ChangeLog: Implement LaunchINFSection on top of DoInfInstall I'm afraid this implementation isn't correct. DoInfInstall calls SetupInstallFromInfSection which only concerns the Install section of an INF file.

Re: advpack: Implement LaunchINFSection on top of DoInfInstall

2006-01-13 Thread James Hawkins
On 1/12/06, Markus Amsler <[EMAIL PROTECTED]> wrote: > ChangeLog: > Implement LaunchINFSection on top of DoInfInstall > I'm afraid this implementation isn't correct. DoInfInstall calls SetupInstallFromInfSection which only concerns the Install section of an INF file. SetupInstallFromInfSection a