Re: advapi32: sign-compare fixes

2007-02-08 Thread Francois Gouget
On Wed, 7 Feb 2007, Vitaliy Margolen wrote: [...] > This isn't correct either. lstrlenW() also returns INT and you > can't just cast it to (unsigned). Unsigned what? int/long/dword? In C, 'unsigned' is synonymous with 'unsigned int'. So it's unambiguous. -- Francois Gouget <[EMAIL PROTECTED]>

Re: advapi32: sign-compare fixes

2007-02-07 Thread Joris Huizer
Vitaliy Margolen <[EMAIL PROTECTED]> wrote: Joris Huizer wrote: > - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, > + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, This isn't right. WideCharToMultiByte returns INT, which is signed. > @@ -1995,11 +1995,11

Re: advapi32: sign-compare fixes

2007-02-07 Thread Vitaliy Margolen
Joris Huizer wrote: > - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, > + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, This isn't right. WideCharToMultiByte returns INT, which is signed. > @@ -1995,11 +1995,11 @@ LookupAccountSidW( > > if (dm) { >