Re: advapi32: Fix comparisons of unsigned expressions with zero

2006-12-08 Thread Andrew Talbot
Mike McCormack wrote: > > Andrew Talbot wrote: > >> -if( n < 0 ) >> +if( (LONG)n < 0 ) > > Why not change the type of n to LONG rather than using a cast? > > Mike Hi Mike, Long answer (no pun intended): There were two ways to jump: I could either have, as you say, made n long, so it

Re: advapi32: Fix comparisons of unsigned expressions with zero

2006-12-07 Thread Mike McCormack
Andrew Talbot wrote: -if( n < 0 ) +if( (LONG)n < 0 ) Why not change the type of n to LONG rather than using a cast? Mike