Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > If you have time available, could you explain what the different cases > are for putting the checks in either ntdll or the wine server. In the > meantime I will be reading through the server's reg functions and > adding the checks there. If the functio

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread James Hawkins
On 23 Feb 2005 16:00:04 +0100, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > James Hawkins <[EMAIL PROTECTED]> writes: > > > By lower level functions do you mean the ntdll reg functions? > > Either in ntdll or directly in the Wine server, depending on the case; > most likely in the server. >

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > By lower level functions do you mean the ntdll reg functions? Either in ntdll or directly in the Wine server, depending on the case; most likely in the server. -- Alexandre Julliard [EMAIL PROTECTED]

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread James Hawkins
On 23 Feb 2005 13:57:08 +0100, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > James Hawkins <[EMAIL PROTECTED]> writes: > > > +/* a key cannot be created directly beneath HKEY_LOCAL_MACHINE or > > HKEY_USERS */ > > +if ((hkey == HKEY_LOCAL_MACHINE || hkey == HKEY_USERS) && > > !strchr(n

Re: advapi32: Add RegCreate/DeleteKey tests and fixes

2005-02-23 Thread Alexandre Julliard
James Hawkins <[EMAIL PROTECTED]> writes: > +/* a key cannot be created directly beneath HKEY_LOCAL_MACHINE or > HKEY_USERS */ > +if ((hkey == HKEY_LOCAL_MACHINE || hkey == HKEY_USERS) && !strchr(name, > '\\')) { > +*retkey = NULL; > + return ERROR_INVALID_PARAMETER; > +}